Fix FFG-SWRPG-Dice-Roller broken dice image URLs in v6.4.4#2190
Fix FFG-SWRPG-Dice-Roller broken dice image URLs in v6.4.4#2190kayochao wants to merge 14 commits intoRoll20:masterfrom
Conversation
|
Looks great! Only minor change I'd suggest is adding yourself to the authors/roll20userid fields in script.json to make sure your efforts are recognised :) |
FFG-SWRPG-Dice-Roller/script.json
Outdated
| "description": "This is the Fantasy Flight Games Star Wars Role Playing Game Dice Roller. It is used in combination with the Star Wars FFG API-Compatible Character Sheet.\n\n**Version 2.6** - Compatible with Depreciated Star Wars - Edge of the Empire (API-Compatible) Character Sheet\n**Version 3.0** - Compatible with Depreciated Star Wars - Edge of the Empire (API-Compatible) Character Sheet - Added Destiny Rolls\n**Version 4.0.2.17** - Compatible with Depreciated Star Wars - Edge of the Empire (API-Compatible) Character Sheet - Added code cleanup and Character Sheet Auto Creator\n**Version 4.0.4.2** - Not Compatible with Depreciated Star Wars - Edge of the Empire (API-Compatible) Character Sheet - Needs to use 4.0.4.0 or higher to utilize. - Added Roll Templates\n**Version 6.3.0** - Added Skill Roll Suggestion Engine, NPC Sheet, collapsible sections, and much more\n**Version 6.4.3** - Updated dice icons for UK users.\n**Version 6.4.4** - Replaced broken imgbox dice URLs with direct links to the dice images already stored in this repository.\n\nSupports dice rolling with graphics, Destiny Point Tracking, Critical Injury/Hit Rolls, Over Encumbrance auto setback adding, Skill Rolls, Opposed Rolls, Initiative Rolls, Auto Character Sheet creation, and Debugging.\n\n**API Commands:**\n**!eed g# y# b# blk# r# p# w# or g#+# or g#-#** - Rolls Dice\n**!eed CharacterID(character) destiny RegisterPlayer** - Syncs Destiny Pool to what is listed on the GM's sheet (typically only done by players).\n**!eed characterID(character) 1w destiny doRoll** - Roll a Destiny Point\n**!eed characterID(character) destiny useLight** - Use a Light Side Destiny Point\n**!eed characterID(character) destiny sendUpdate** - Force the Players to update their Destiny Point display (typically only done by the GM).\n**!eed characterID(character) destiny clearPool** - Clear the Destiny Pool\n**!eed characterID(character) destiny useDark** - Use a Dark Side Destiny Point\n**!eed resetdice characterID** - Reset Dice in the Dice Pool\n**crit(roll) crit(roll|#) crit(heal|#)** - Apply a Critical Injury - Added to !eed dice rolls\n**critShip(roll) critShip(roll|#) critShip(heal|#)** - Apply a Critical Hit - Added to !eed dice rolls\n**encum(encum_current|encum_threshold)** - Check if over encumberance threshold - Added to !eed dice rolls\n**skill(char_value|skill_value)** - Roll a Skill - Added to !eed dice rolls\n**opposed(char_value|skill_value)** - Roll an Opposed check - Added to !eed dice rolls\n**!eed log on|off|multi|single** - Logging Options\n**!eed graphics on|off|s|m|l** - Graphics Options\n**!eed test** - Test 1 of each die.\n**!eed debug on|off** - Debug mode.\n**label(Name of Skill)** - Label a skill roll.\n**npcinit or pcinit and #b #g #y #blk #p #r #w** - Roll an Initiative Check. - Added to !eed dice rolls\n**upgrade(ability|#) or upgrade(difficulty|#)** - Upgrade the ability or Difficulty of a check. - Added to !eed dice rolls\n**downgrade(proficiency|#) or downgrade(challenge|#)** - Downgrade the ability or Difficulty of a check. - Added to !eed dice rolls\n**!charsheet** - Create a blank Character Sheet.", | ||
| "authors": "Konrad J.,Steve Day, Arron, Andrew H., Tom F., Akashan, GM Knowledge Rhino,Tim P., Hannah Eliz, Flo Wild", | ||
| "authors": "Konrad J.,Steve Day, Arron, Andrew H., Tom F., Akashan, GM Knowledge Rhino,Tim P., Hannah Eliz, Flo Wild, kayochao", | ||
| "roll20userid": "77736,446406,104025,45755,193829,173154,472728,1190923,238289", |
There was a problem hiding this comment.
If you add your user id here, I think it'll also add the API Scripter tag to your account in roll20 and its forums. You can find your number in the url of your profile page: https://app.roll20.net/users/*insertThisNumber*/yourUserName ^_^
There was a problem hiding this comment.
oh my, whatever would i do without you henry! new world for me lol. i appreciate your help more than i can describe :)))
There was a problem hiding this comment.
Hey @kayochao, in order for the update to work we do require that you create a folder named after the updated version.
The Folder should then contain the updated FFG-SWRPG-Dice-Roller.js file. Please take a look at the current structure of the FFG-SWRPG-Dice-Roller - 6.4.3 folder for an example: https://github.com/Roll20/roll20-api-scripts/tree/master/FFG-SWRPG-Dice-Roller
This PR publishes v6.4.4 of FFG-SWRPG-Dice-Roller and fixes broken dice graphics by replacing the current imgbox URLs with direct links to the dice image assets already stored in this repository.
Fixes #2172.
Changes:
Background:
The 6.4.3 release switched dice graphics to imgbox-hosted URLs. Those links no longer render correctly for Roll20 chat output, causing broken dice face images. This update keeps the existing dice assets in the repository and points the script at direct image URLs instead.