Open
Conversation
|
Can we get this merged please? |
|
PSR4 Specs state:
So I'm personally not a fan of the Would you reconsider this, reverse the pull request, and instead rename the file to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Renamed the RESO class to Reso for psr4 compliance. The class name needs to be the same as the file name, including capitalization. The examples worked fine when I was testing the code, but when I imported into a symfony PHP project, I received the error regarding psr4 autoloading similar to issue: #9 (comment)
Also added a new cli example for connecting to the bridge web api using only the server token provided by bridge.
Benefits
Ability to autoload in projects that require psr4 autoloading
Possible Drawbacks
None
Verification Process
After importing to symfony project and getting the error. I renamed the class file and dumped the composer autoload file. The result was no errors and I was able to make a connection to the web api and pull property data.
Applicable Issues
None