Update GHA TPL cache; resolve new test failures#3865
Open
jsiirola wants to merge 35 commits intoPyomo:mainfrom
Open
Update GHA TPL cache; resolve new test failures#3865jsiirola wants to merge 35 commits intoPyomo:mainfrom
jsiirola wants to merge 35 commits intoPyomo:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3865 +/- ##
==========================================
- Coverage 89.65% 88.29% -1.36%
==========================================
Files 908 908
Lines 106757 106732 -25
==========================================
- Hits 95715 94244 -1471
- Misses 11042 12488 +1446
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrmundt
requested changes
Mar 2, 2026
|
|
||
| - os: windows-latest | ||
| python: 3.14 | ||
| python: 3.13 |
Contributor
There was a problem hiding this comment.
This one was intentionally on 3.14 because that's where a lot of Windows weirdness seems to happen lately.
| $osxarch = (uname -m).Trim() | ||
| if ( "$osxarch" -eq "arm64" ) { | ||
| $URL = "$URL/macosx/osx_arm64_sfx.exe" | ||
| } else { |
Contributor
There was a problem hiding this comment.
Why have this logic if we are skipping OSX?
| ext() | ||
| result = " OK " | ||
| else: | ||
| # If the extension has a __cell__(), then call |
Contributor
There was a problem hiding this comment.
Suggested change
| # If the extension has a __cell__(), then call | |
| # If the extension has a __call__(), then call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
This updates the GHA TPL caches. Sort of. We are updating GAMS to the almost-current version (52.5) because the current version (53.1) causes segfaults (at least under pytest). The updated versions led to some test errors that this PR also resolves:
While working on things, some other things were cleaned up:
download-extensionscommandcurlrcfor passing standard options to curltest-branchespython versions to get better coverage without adding testsNOTE: the intent is to let this PR build and generate the new caches, then we will update the PR to unpin GAMS (but not trigger the caches to be rebuilt).
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: