[WIP] Use a different partition for plugins. #502
Open
sambitmishra98 wants to merge 1 commit intoPyFR:developfrom
Open
[WIP] Use a different partition for plugins. #502sambitmishra98 wants to merge 1 commit intoPyFR:developfrom
sambitmishra98 wants to merge 1 commit intoPyFR:developfrom
Conversation
Contributor
|
So we really want to make this 100% transparent for the plugins. As in rework the plugin architecture a little so that this PR would not require plugins to opt in at all. A good test for this is the Ascent plugin. We also want to handle the case where multiple plugins use the same data (solution etc.) with the same partitioning and avoid having to send it over again. |
Contributor
Author
|
I will add in an extra CLI argument to run/restart similar to the way we ask for a partition, instead of using the config file. |
Contributor
|
It can still be in the ini file, just handled by BasePlugin. Key thing is all plugins should work with zero changes needed. |
bf1af8e to
8da49df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an opt-in path to redistribute element-indexed data from the solver’s mesh partitioning to a separate plugin partitioning. Set partition = in a plugin’s (e.g., writer or tavg) config block to load that partition for the plugin; the runtime will build an interconnector from the compute mesh to the plugin mesh and relocate array data across ranks before outputting to disk. If partition is omitted, behavior is unchanged and data is written using the compute partition. For now, ensure all writer/tavg plugins reference the same partition name.