[vi-mode] Supports 'diw' text-object command.#2059
Merged
daxian-dbw merged 9 commits intoPowerShell:masterfrom Aug 14, 2023
Merged
[vi-mode] Supports 'diw' text-object command.#2059daxian-dbw merged 9 commits intoPowerShell:masterfrom
daxian-dbw merged 9 commits intoPowerShell:masterfrom
Conversation
24dbaa4 to
c8cf272
Compare
Member
|
@springcomp I resolved the conflicts. Will finish the review tonight. |
daxian-dbw
reviewed
Feb 11, 2021
This was referenced Aug 23, 2023
6 tasks
|
Can we have it exposed to |
Contributor
Author
Unfortunately, that PR has been merged a bit too quickly. I addressed feedback from follow up conversations in a future pull request that addresses this shortcomings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #2057.
This PR is a first attempt at supporting text-objects in vi-mode. It includes a reasonably complete implementation of the diw command.
Although I have worked hard to make this PR production ready, it must still be considered WIP. I would really appreciate feedback about the implementation.
If this is deemed interesting enough, it could be the first step towards a much complete set of pull requests as alluded to in #584.
PR Checklist
Microsoft Reviewers: Open in CodeFlow