Fix infinite loop crash when Levels Gamma is set to 0#2041
Open
levanel wants to merge 1 commit intoPintaProject:masterfrom
Open
Fix infinite loop crash when Levels Gamma is set to 0#2041levanel wants to merge 1 commit intoPintaProject:masterfrom
levanel wants to merge 1 commit intoPintaProject:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2035
Description
This PR fixes a bug where the application permanently freezes if the user drags the gamma (midtones) slider down to 0.
The freeze was caused by an infinite do-while loop in {UpdateGammaByMask(float val)}. The UI allows the user to request a value of 0 , but the underlying engine strictly clamps Gamma to a minimum of 0.1 . Because the target value could never be reached, the loop never exited locking up the main thread.
Changes
Added 'val = Math.Clamp(val, 0.1f, 10.0f);' at the start of {UpdateGammaByMask} in Effects.LevelsDialog.cs to ensure the requested value matches the physical limits before the loop begins.