Skip to content

Makes the outline width and dash widgets on the Freeform Shape Tool only visible when there is a stroke#2039

Open
pedropaulosuzuki wants to merge 3 commits intoPintaProject:masterfrom
pedropaulosuzuki:freeform_shape_visible
Open

Makes the outline width and dash widgets on the Freeform Shape Tool only visible when there is a stroke#2039
pedropaulosuzuki wants to merge 3 commits intoPintaProject:masterfrom
pedropaulosuzuki:freeform_shape_visible

Conversation

@pedropaulosuzuki
Copy link
Contributor

@pedropaulosuzuki pedropaulosuzuki commented Mar 13, 2026

Finalizes #2012.

No need to squash this time, no linter complaints!

@pedropaulosuzuki pedropaulosuzuki changed the title Makes the dash widget on the Freeform Shape Tool only visible when there is a stroke Makes the outline width and dash widgets on the Freeform Shape Tool only visible when there is a stroke Mar 14, 2026
@pedropaulosuzuki pedropaulosuzuki marked this pull request as ready for review March 14, 2026 00:13
@Lehonti
Copy link
Contributor

Lehonti commented Mar 14, 2026

@pedropaulosuzuki, for linking issues (so that they are automatically closed when the merge happens), github recognizes specific keywords (finalizes is not among them). I suggest using closes :)

https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

@pedropaulosuzuki
Copy link
Contributor Author

pedropaulosuzuki commented Mar 14, 2026

@pedropaulosuzuki, for linking issues (so that they are automatically closed when the merge happens), github recognizes specific keywords (finalizes is not among them). I suggest using closes :)

https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

I used "finalizes" because this is part 2 of #2019. Using Github keywords was not the intention here. Github assuming stuff is always annoying, as when a "fixes" becomes "partially fixes" at some point and the original issue still gets closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants