Background of oval selection doesn't get replaced with transparency#2024
Open
Lehonti wants to merge 2 commits intoPintaProject:masterfrom
Open
Background of oval selection doesn't get replaced with transparency#2024Lehonti wants to merge 2 commits intoPintaProject:masterfrom
Lehonti wants to merge 2 commits intoPintaProject:masterfrom
Conversation
Member
Contributor
|
I personally would expect 'replace' on paste, instead of 'alpha over', unless it was pasted into a new layer. The ideal solution would be to mask the selection without using the alpha channel, but a separate bitmap, so we could paste non-rectangular selections, but without messing the alpha channel. If that isn't possible, maybe spawning a new layer on paste wouldn't be the worst of the compromises, as this wouldn't destroy the underlying pixels, but could create friction for some users. We could also add a toggle that changed this behavior in the toolbar in some way. I feel like just doing alpha over could be a regression, in some sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1385
With a caveat: when moving parts of a translucent image, the behavior is different.
Before (replacement):
After (overlap):
And for reference, issue #840 changed the behavior to replace the area below with the selection, so this would be some kind of rollback, but if this is not desired we can try to find some way to fix the bug without changing the behavior.