Skip to content

Refactor/change management in transaction#121

Open
tejaede wants to merge 2 commits intomainfrom
refactor/change-management-in-transaction
Open

Refactor/change management in transaction#121
tejaede wants to merge 2 commits intomainfrom
refactor/change-management-in-transaction

Conversation

@tejaede
Copy link
Collaborator

@tejaede tejaede commented Mar 10, 2026

This is the implementation of the solution described here: #114 (comment)

A couple of notes

  • DataService.handleChange does 2 things.
      1. Pass the event to the transaction managing the object
      1. Set the inverse values
  • DataService methods that manipulate createdDataObjects, deletedDataObjects, changedDataObjects, and dataObjectChanges are now just proxies to a transaction. For example...
        registerChangedDataObject: {
            value: function (dataObject) {
                let transaction = this._transactionForObject(dataObject);
                transaction.registerChangedDataObject(dataObject);
            },
        },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant