fix: correct MissingFireResist typo in statList for missing elemental… #9457
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resistance The combined "per X% missing fire, cold, or lightning resistance" pattern duplicated MissingFireResist instead of using MissingLightningResist as the third stat, causing Replica Nebulis to ignore missing lightning res.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
ModParser.lua:1438: thestatListfor "per X% missing fire, cold, or lightning resistance" has"MissingFireResist"duplicated in the 3rd position instead of"MissingLightningResist"Details
The pattern at line 1438:
["per (%d+)%% missing fire, cold, or lightning resistance, up to a maximum of (%d+)%%"]has
statList = { "MissingFireResist", "MissingColdResist", "MissingFireResist" }. The third element should be "MissingLightningResist".This means Replica Nebulis double-counts missing fire resistance and ignores missing lightning resistance when calculating the combined "fire, cold, or lightning" variant.