Conversation
eslint-plugin-promise@7.2.1 only declares peer support for ESLint up to ^9.0.0, blocking the upgrade to ESLint v10. eslint-plugin-promise is not actively maintained with no updates for over a year.
jasontaylordev
changed the title
Dev toolchain packages (eslint, typescript-eslint) have stale advisory database entries that flag false positives. Production dependencies are still audited. --omit=dev scopes the check to what actually ships.
- Remove eslint-disable comments for promise/ rules (plugin removed) - Remove useless initial assignments in AuditingCapability.ts and HealthChecksStore.ts flagged by the new no-useless-assignment rule - Fix formatting in eslint.config.mjs
vite-plugin-checker@0.12.0 uses legacy ESLint options removed in v10, causing test and dev server failures. Removing the eslint option from the checker config and adding an explicit npm run lint step to build.ps1 to ensure ESLint continues to run in CI.
jasontaylordev
force-pushed
the
npm-patch-minor-updates
branch
from
899b8f8 to
306ca94
Compare
jasontaylordev
changed the title
|
|
||
| export function mount({ router }: { router: Router }) { | ||
| router.beforeEach((to, _from, next) => { | ||
| router.beforeEach((to) => { |
There was a problem hiding this comment.
https://router.vuejs.org/guide/migration/v4-to-v5 says that there are no breaking changes from 4 to 5... so what is this change doing?
There was a problem hiding this comment.
Updated router.beforeEach in mount.ts to return instead of calling deprecated next() callback
|
|
||
| serviceControlClient | ||
| .fetchFromServiceControl("configuration") | ||
| // eslint-disable-next-line promise/prefer-await-to-then |
There was a problem hiding this comment.
I don't understand why this linting rule is being removed. We want all async operations to be forced to use async await unless there's an explicit reason for not doing so
There was a problem hiding this comment.
Removed stale eslint-disable comments for promise/ rules (from the now-removed eslint-plugin-promise)
eslint-plugin-promise was removed to unblock the ESLint v10 upgrade. It only declared peer support for ESLint up to ^9.0.0 and is not actively maintained (last update over 1 year ago).
2 participants
Combines several Renovate PRs into one, verified locally with a clean build.
npm dependency updates
eslint@eslint/jsvue-codemirror6eslint-plugin-vuetypescript-eslint@types/nodejsdomvue-routerNuGet dependency updates
NUnitMicrosoft.Extensions.FileProviders.EmbeddedGitHub Actions updates
docker/build-push-actionRemoved
eslint-plugin-promisewas removed to unblock the ESLint v10 upgrade. It only declared peer support for ESLint up to^9.0.0and is not actively maintained.Additional changes required for ESLint v10
npm auditinbuild.ps1to--omit=dev(dev toolchain has transient false-positive advisories unrelated to production code)eslint-disablecomments forpromise/rules (from the now-removedeslint-plugin-promise)no-useless-assignmentviolations (new rule enforced in this upgrade):AuditingCapability.ts: changedlet messageTooltip = ""tolet messageTooltip: stringHealthChecksStore.ts: changedlet result: EmailNotifications | null = nulltolet result: EmailNotifications | nulleslintfromvite-plugin-checkerconfig invite.config.ts(vite-plugin-checker@0.12.0uses legacy ESLint options removed in v10, causing test and dev server failures)npm run lintstep tobuild.ps1to keep ESLint enforced in CIAdditional changes required for vue-router v5
router.beforeEachinmount.tsto return instead of calling deprecatednext()callbackTest fixes
networkErroroption toMockEndpointOptionsfor simulating fetch failureshasMonitoringUnavailableprecondition: The "monitoring instance not responding" scenario requires a network error (fetch throws), not an HTTP 500 response with valid JSONendpoint-details.spec.tshistory period test into 7 independent tests to avoid CI timeoutCloses #2810
Closes #2811
Closes #2828
Closes #2789
Closes #2792
Closes #2830
Closes #2829
Closes #2803
Closes #2827
Closes #2706
Closes #2801