Fix URIFactoryTest failing on Windows#7527
Merged
karianna merged 6 commits intoPCGen:masterfrom Feb 26, 2026
Merged
Conversation
…continue_gh_actions
Use File.toURI() instead of manually constructing a URI string with
new URI("file:" + path). On Windows, System.getProperty("user.dir")
returns backslash-separated paths (e.g. D:\a\pcgen\pcgen) which are
illegal characters in a URI, causing URISyntaxException.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
URIFactoryTest.testGetURI_WithValidRootAndOffset()fails on Windows CI runners with:The test constructed the expected URI via
new URI("file:" + System.getProperty("user.dir") + "/data/file.txt"). On Windows,user.dircontains backslashes (e.g.D:\a\pcgen\pcgen) which are illegal in URIs.Fix
Use
new File(System.getProperty("user.dir"), "data/file.txt").toURI()which produces a properly formattedfile:///URI with forward slashes on all platforms.