Karianna's fork of Vests gh_build PR

[karianna]

• Move to 17.0.7
• Add runtime dependency
• Update to latest launch4j and fix a security warning
• Fixed: PCClassTest - renamed CLASSTYPE to TYPE in sample data. (Fixed: PCClassTest - renamed CLASSTYPE to TYPE in sample data. #6881)
• Fixed: pcGenGUIPfrpgRogueTest by removing two traits from pf_Rogue.xml, removed empty tabs from XML, renamed "Case (Map or Scroll)" to "Map Case", because the previous item doesn't exist in Pathfinder. (Fixed: pcGenGUIPfrpgRogueTest #6883)
• Fixed: Updated expected templates (csheet files) (Fixed: Updated expected templates (csheet files) #6885)
• Fix Goldielocks
• Movement wasn't connected. Fix Movement. (Precursor to moving to new formula system)
• Fixed: Updated expected templates (csheet files) (Fixed: Updated expected templates (csheet files) #6887)
• Update the SF Mechanic Character to incorporate updates
• Update the SF Soldier
• Fix the Master Crafter feat
• Fix Unreferenced Campaign sources
• Fix Choose for Wind Dance Martial Arts Style
• Minor fix for Variant Tiefling Ability
• Allow 1-hander slashing weapons to qualify for Slashing Grace (Falcata, Khopesh, and Temple Sword)
• Remove illegal ’ and convert to proper ' from PRECAMPAIGN tag.
• Fixed integration tests related to Startfinder (Fixed integration tests related to Startfinder #6890)
• Fix Data Size issues
• Fix Orphaned File error
• Create stub for Blood of the Ancient - removes an orphan issue and can't find campaign via PRECAMPAIGN issue
• DATA-4325 Typo in Inner Sea Races
• Fixed a bug, when the OutputPanel couldn't show the file chooser dialog, because the underlying code works in Swing threads only. Now the entire content of the panel is running in JavaFX thread. (Fixed a bug, when the OutputPanel couldn't show the file chooser dialog #6896)
• Bump org.springframework:spring-beans from 6.0.10 to 6.0.11 (Bump org.springframework:spring-beans from 6.0.10 to 6.0.11 #6899)
• Bump org.springframework:spring-web from 6.0.10 to 6.0.11 (Bump org.springframework:spring-web from 6.0.10 to 6.0.11 #6898)
• Bump org.springframework:spring-core from 6.0.10 to 6.0.11 (Bump org.springframework:spring-core from 6.0.10 to 6.0.11 #6897)
• gradle investigation
• Newsource 424 (Newsource 424 #6901)
• Newsource 435 (Newsource 435 #6900)
• Bump org.junit.jupiter:junit-jupiter-params from 5.9.3 to 5.10.0 (Bump org.junit.jupiter:junit-jupiter-params from 5.9.3 to 5.10.0 #6902)
• Bump org.junit.platform:junit-platform-runner from 1.9.3 to 1.10.0 (Bump org.junit.platform:junit-platform-runner from 1.9.3 to 1.10.0 #6906)
• Bump org.junit.jupiter:junit-jupiter-api from 5.9.3 to 5.10.0 (Bump org.junit.jupiter:junit-jupiter-api from 5.9.3 to 5.10.0 #6905)
• Bump org.junit.jupiter:junit-jupiter-engine from 5.9.3 to 5.10.0 (Bump org.junit.jupiter:junit-jupiter-engine from 5.9.3 to 5.10.0 #6903)
• Bump org.junit.platform:junit-platform-launcher from 1.9.3 to 1.10.0 (Bump org.junit.platform:junit-platform-launcher from 1.9.3 to 1.10.0 #6904)
• Fixed Newsource 424 #6901: fixed the Piazo - Near Space cover. (Fixed #6901: fixed the Piazo - Near Space cover #6907)
• Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.13.0 (Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.13.0 #6908)
• Bump edu.sc.seis.launch4j from 3.0.3 to 3.0.4 (Bump edu.sc.seis.launch4j from 3.0.3 to 3.0.4 #6909)
• Bump com.github.spotbugs from 5.0.14 to 5.1.0 (Bump com.github.spotbugs from 5.0.14 to 5.1.0 #6910)
• Bump com.github.spotbugs from 5.1.0 to 5.1.1
• Bump com.github.spotbugs from 5.1.1 to 5.1.2 (Bump com.github.spotbugs from 5.1.1 to 5.1.2 #6912)
• Spaces before tags; symbols we avoid; and outputsheet improvements
• Bump com.github.spotbugs from 5.1.2 to 5.1.3 (Bump com.github.spotbugs from 5.1.2 to 5.1.3 #6913)
• Bump org.apache.xmlgraphics:fop from 2.8 to 2.9 (Bump org.apache.xmlgraphics:fop from 2.8 to 2.9 #6915)
• fix checkstyle warning
• Added initial GH action support
• Upgraded gradle wrapper to 8.11.1.
• Added testing to gh-action.
• First attempt to log data in test. It failed in GH actions.
• Added the logging to all tests.
• Added gradle cache to a github action setup-java.
• Disabled logging, but added the test results upload.
• Enabled "write" permissions for test results
• Refactored TestHelper.java Added some logging.
• Updated cache-dependency-path.
• First attempt to cache build/classes and build/jre
• Corrected a typo in gradle.yml
• Try to clear the cache and fill it with values.
• First step to remove NSIS from the distro; Removed explicit System.exit(0) in Main. It allows to enable "slowtest" that generates and compares XMLs. Marked SystemExitInterceptor as deprecated and removal=true. Since Java does not offer any alternative, we have to find a better solution. P.S. NSIS is planned to be removed to use jpackage only.
• Performance optimization: the debugPrint (when called frequently) uses StackTrace to determine the logger name. This is expensive and replaced with an explicit logger creation.
• Refactored Logging.java.
• Upgraded gradle-wrapper from 8.11.1 to 8.12
• Remove .run/ from git repository, because it tracked by mistake in Fix code 3533 #7056
• Refactored several classes. The main goal was adding the Optional to methods that return null. In some cases, the null reference/result was not checked, but the code never failed, because it was not executed. There were no tests, that is why it was difficult to check, whether the refactoring was right :(
• Corrected pf_Cleric test; 1. Corrected the typo in special properties (light crossbow); 2. Corrected maxdex for MAXDEX bonus;
• Remove "public" and "abstract" for several interfaces (redundant)
• Added more logging to PcgenFtlTestCase.java (it will help to determine the difference between "golden" and generated files). Trimmed lines in base.xml and base-xml.ftl template.
• *Trimmed different .xml inputs. Corrected pf_Rogue.xml result: +1 reflex comes from Halfling Luch and +3 from his Cloak.
• Updated build.gradle - disable security manager for all Test Gradle "actions" Created a "graceful exit" object + interceptor. It is supposed to replace System.Exit calls in different parts of the project; Updated reporting.gradle by increasing versions of some dependencies; Removed a DM_EXIT rule from spotbugs -> the calls of System.Exit must be replaced with GracefulExit. The decision to create a custom interceptor was taken based on the discussion from Reddit: https://www.reddit.com/r/java/comments/1fpxmfp/jep_486_permanently_disable_the_security_manager/
• Added JavaDoc to Exit and GracefulExit classes.*
• Resolved warnings for Gradle 8.12: "Space-assignment syntax in Groovy DSL has been deprecated."
• Moved GracefulExit from test to main (util). Replaced few System.exit with GracefulExit.exit calls. Refactored few methods to satisfy SonarQube warnings.
• Refactored CommandLineArguments.java to avoid hidden System.exit calls.
• Corrected failed int (slow) tests
• Corrected a wrong assertion message
• Removed SystemExitInterceptor.java, because it was deprecated; Refactored CommandLineArguments and its test. Increased the code coverage.
• Added a checkstyle rule that prevents the project from System.exit usage outside GracefulExit.
• Use the latest version of Freemarker template engine.
• Resolved warnings from Gradle.
• Resolved comments from Github PR. Moved a GUI-error message to the localization file. Formatted error messages
• JaCoCo was added to github actions - now it shows the high-level code coverage my tests
• Create a jpackage build.
• First attempt to build releases for all OSes.
• Changed the event to build a release conditionally.
• Update gradle-release.yml
• Corrected the artifact name
• Attempt to create releases
• Attempt to create releases (v2)
• Corrected the artifact creation.
• Attempt to create one more release
• Updated JDK from 21.0.5 to 21.0.6
• Corrected a build for Windows (at least). gradle jpackageImage
• Added ubuntu-24-arm
• Added a hotfix to repair linux-arm build.
• Update Gradle wrapper to version 8.13 and fix output formatting in gradlew
• Update Gradle wrapper to version 8.14
• Removed jar-export-plugins from pluginbuild.xml Added the same task to plugins.gradle
• Update Appveyor config to adjust Gradle commands and formatting
• Remove Ant-based build files for Gradle-only build system
• Update properties and refine Gradle plugin Jar tasks
• Refactor code style by removing unnecessary whitespace and updating method signatures in PCGenTaskExecutor and PluginLoader
• Refactored and changed files that didn't pass gradle checkstyleMain Few recent pull requests broke the styling: Info export #7319
• Refactored and changed files that didn't pass gradle checkstyleMain Few recent pull requests broke the styling: Info export #7319
• Refactor PluginClassLoader
• Add plugins.gradle to Gradle configuration for release and test workflows
• Update Gradle wrapper to version 9.0.0 and fix classpath configuration in wrapper scripts
• Update JavaFX version to 21.0.8 and improve URIFactory error handling with new tests
• Improve README formatting and grammar for clarity and consistency
• Refactor test task configurations to use correct directory paths for test classes
• Set name and description for code review agent
• Create Security Review Agent documentation
• Rename my-agent.md to my-code-review-agent.md
• Changed PluginBuildTest, because the new plugins are built from corresponding .java files. The slow test has been reverted, because it was broken in old commits (DATA-4372)
• Updated Java to 21.0.8 (mac aarch64) Gradle wrapper to 9.1.0
• Update Gradle wrapper to version 9.2.0 and refactor dependency declarations to avoid Gradle's warnings. Such constructions will be deprecated in Gradle 10.
• Update Java&JavaFX to 25.0.1 and JaCoCo to 0.8.14 versions in build.gradle
• Add native access flags for JavaFX modules in distribution.gradle
• Refactor JavaFX resource loading by introducing PanelFromResource utility class
• Reverted a part of 6.09.info #7462, that broke DescriptionTest.
• Update FXML files to use JavaFX 25.0.1 namespace
• Corrected checkstyle findings
• Added initial GH action support
• Upgraded gradle wrapper to 8.11.1.
• Added testing to gh-action.
• First attempt to log data in test. It failed in GH actions.
• Added the logging to all tests.
• Added gradle cache to a github action setup-java.
• Disabled logging, but added the test results upload.
• Enabled "write" permissions for test results
• Refactored TestHelper.java Added some logging.
• Updated cache-dependency-path.
• First attempt to cache build/classes and build/jre
• Corrected a typo in gradle.yml
• Try to clear the cache and fill it with values.
• First step to remove NSIS from the distro; Removed explicit System.exit(0) in Main. It allows to enable "slowtest" that generates and compares XMLs. Marked SystemExitInterceptor as deprecated and removal=true. Since Java does not offer any alternative, we have to find a better solution. P.S. NSIS is planned to be removed to use jpackage only.
• Performance optimization: the debugPrint (when called frequently) uses StackTrace to determine the logger name. This is expensive and replaced with an explicit logger creation.
• Refactored Logging.java.
• Upgraded gradle-wrapper from 8.11.1 to 8.12
• Remove .run/ from git repository, because it tracked by mistake in Fix code 3533 #7056
• Refactored several classes. The main goal was adding the Optional to methods that return null. In some cases, the null reference/result was not checked, but the code never failed, because it was not executed. There were no tests, that is why it was difficult to check, whether the refactoring was right :(
• Updated PMD to 7.17 Added many rules to ruleset.xml Fixed few warnings Enabled config-cache for testing purposes.
• Corrected pf_Cleric test; 1. Corrected the typo in special properties (light crossbow); 2. Corrected maxdex for MAXDEX bonus;
• Remove "public" and "abstract" for several interfaces (redundant)
• Added more logging to PcgenFtlTestCase.java (it will help to determine the difference between "golden" and generated files). Trimmed lines in base.xml and base-xml.ftl template.
• *Trimmed different .xml inputs. Corrected pf_Rogue.xml result: +1 reflex comes from Halfling Luch and +3 from his Cloak.
• Updated build.gradle - disable security manager for all Test Gradle "actions" Created a "graceful exit" object + interceptor. It is supposed to replace System.Exit calls in different parts of the project; Updated reporting.gradle by increasing versions of some dependencies; Removed a DM_EXIT rule from spotbugs -> the calls of System.Exit must be replaced with GracefulExit. The decision to create a custom interceptor was taken based on the discussion from Reddit: https://www.reddit.com/r/java/comments/1fpxmfp/jep_486_permanently_disable_the_security_manager/
• Added JavaDoc to Exit and GracefulExit classes.*
• Resolved warnings for Gradle 8.12: "Space-assignment syntax in Groovy DSL has been deprecated."
• Moved GracefulExit from test to main (util). Replaced few System.exit with GracefulExit.exit calls. Refactored few methods to satisfy SonarQube warnings.
• Refactored CommandLineArguments.java to avoid hidden System.exit calls.
• Corrected failed int (slow) tests
• Corrected a wrong assertion message
• Removed SystemExitInterceptor.java, because it was deprecated; Refactored CommandLineArguments and its test. Increased the code coverage.
• Added a checkstyle rule that prevents the project from System.exit usage outside GracefulExit.
• Use the latest version of Freemarker template engine.
• Resolved warnings from Gradle.
• Resolved comments from Github PR. Moved a GUI-error message to the localization file. Formatted error messages
• JaCoCo was added to github actions - now it shows the high-level code coverage my tests
• Create a jpackage build.
• First attempt to build releases for all OSes.
• Changed the event to build a release conditionally.
• Update gradle-release.yml
• Corrected the artifact name
• Attempt to create releases
• Attempt to create releases (v2)
• Corrected the artifact creation.
• Attempt to create one more release
• Updated JDK from 21.0.5 to 21.0.6
• Corrected a build for Windows (at least). gradle jpackageImage
• Added ubuntu-24-arm
• Added a hotfix to repair linux-arm build.
• Update Gradle wrapper to version 8.13 and fix output formatting in gradlew
• Update Gradle wrapper to version 8.14
• Removed jar-export-plugins from pluginbuild.xml Added the same task to plugins.gradle
• Update Appveyor config to adjust Gradle commands and formatting
• Remove Ant-based build files for Gradle-only build system
• Update properties and refine Gradle plugin Jar tasks
• Refactor code style by removing unnecessary whitespace and updating method signatures in PCGenTaskExecutor and PluginLoader
• Refactored and changed files that didn't pass gradle checkstyleMain Few recent pull requests broke the styling: Info export #7319
• Refactored and changed files that didn't pass gradle checkstyleMain Few recent pull requests broke the styling: Info export #7319
• Refactor PluginClassLoader
• Add plugins.gradle to Gradle configuration for release and test workflows
• Update Gradle wrapper to version 9.0.0 and fix classpath configuration in wrapper scripts
• Update JavaFX version to 21.0.8 and improve URIFactory error handling with new tests
• Improve README formatting and grammar for clarity and consistency
• Refactor test task configurations to use correct directory paths for test classes
• Changed PluginBuildTest, because the new plugins are built from corresponding .java files. The slow test has been reverted, because it was broken in old commits (DATA-4372)
• Updated Java to 21.0.8 (mac aarch64) Gradle wrapper to 9.1.0
• DATA-4380 - 3.5e - Enable Jack Of All Trades to display 'Untrained' class skills
• DATA-4379 - d20 modern, taking magical heritage, the 3 cantrips aren't selectable 6.08.00 rc10
• DATA-4381 - PF1e - Racial Heritage in Mythic not implemented
• DATA-4381 - PF1e - Racial Heritage in Mythic not implemented
• DATA-4383
• DATA-4384
• DATA-4384
• Bump com.github.spotbugs from 6.4.2 to 6.4.4 (Bump com.github.spotbugs from 6.4.2 to 6.4.4 #7453)
• Bump org.springframework:spring-beans from 6.2.11 to 6.2.12 (Bump org.springframework:spring-beans from 6.2.11 to 6.2.12 #7446)
• Bump com.github.spotbugs:spotbugs-annotations from 4.9.6 to 4.9.8 (Bump com.github.spotbugs:spotbugs-annotations from 4.9.6 to 4.9.8 #7452)
• DATA-4385
• 6.09.info (6.09.info #7459)
• 6.09.info (6.09.info #7462)
• 6.09.info (6.09.info #7463)
• 6.09.info (6.09.info #7464)
• 6.09.info (6.09.info #7465)
• Update Gradle wrapper to version 9.2.0 and refactor dependency declarations to avoid Gradle's warnings. Such constructions will be deprecated in Gradle 10.
• Update Java&JavaFX to 25.0.1 and JaCoCo to 0.8.14 versions in build.gradle
• Add native access flags for JavaFX modules in distribution.gradle
• Refactor JavaFX resource loading by introducing PanelFromResource utility class
• Reverted a part of 6.09.info #7462, that broke DescriptionTest.
• Update FXML files to use JavaFX 25.0.1 namespace
• Fix remnant issues from PREFACT conversion with multiples lingering from PRERACE
• Clean up
• Fix Non-Monk getting Wisdom bonus.
• Fix a bunch of minor formatting errors in pcc files
• Some textual improvements and typo fixes.
• Corrected checkstyle findings
• Upgrade to Java 25 and fix lots of typos
• Revert failing MULT:YES and fix var name in build script

[Vest]

wow, the tests are green.