Deploy Base 46: upgrade cross-chain remote strategy#2830
Conversation
shahthepro
left a comment
There was a problem hiding this comment.
Compared the "CrossChainRemoteStrategy" contract with address 0xAA8af8Db4B6a827B51786334d26349eb03569731 on base
to local files under folders ".,node_modules"
match @openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol
match @openzeppelin/contracts/token/ERC20/IERC20.sol
match @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match @openzeppelin/contracts/utils/Address.sol
match @openzeppelin/contracts/utils/math/Math.sol
match @openzeppelin/contracts/utils/math/SafeCast.sol
match contracts/governance/Governable.sol
match contracts/governance/Strategizable.sol
match contracts/interfaces/cctp/ICCTP.sol
match contracts/interfaces/IBasicToken.sol
match contracts/interfaces/IMerkl.sol
match contracts/interfaces/IStrategy.sol
match contracts/interfaces/IVault.sol
match contracts/interfaces/morpho/IMorphoV2Adapter.sol
match contracts/interfaces/morpho/IVaultV2.sol
match contracts/strategies/crosschain/AbstractCCTPIntegrator.sol
match contracts/strategies/crosschain/CrossChainRemoteStrategy.sol
match contracts/strategies/crosschain/CrossChainStrategyHelper.sol
match contracts/strategies/Generalized4626Strategy.sol
match contracts/strategies/MorphoV2VaultUtils.sol
match contracts/token/OUSD.sol
match contracts/utils/BytesHelper.sol
match contracts/utils/Helpers.sol
match contracts/utils/Initializable.sol
match contracts/utils/InitializableAbstractStrategy.sol
match contracts/vault/VaultStorage.sol
match lib/openzeppelin/interfaces/IERC4626.sol
shahthepro
left a comment
There was a problem hiding this comment.
- All deployed contracts are listed in the deploy PR's description
- Deployed contract's verified code (and all dependencies) match the code in master
- Contract constructors have correct arguments
- The transactions that interacted with the newly deployed contract match the deploy script.
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
clement-ux
left a comment
There was a problem hiding this comment.
Compared the "CrossChainRemoteStrategy" contract with address 0xAA8af8Db4B6a827B51786334d26349eb03569731 on base
to local files under folders ".,node_modules"
match @openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol
match @openzeppelin/contracts/token/ERC20/IERC20.sol
match @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match @openzeppelin/contracts/utils/Address.sol
match @openzeppelin/contracts/utils/math/Math.sol
match @openzeppelin/contracts/utils/math/SafeCast.sol
match contracts/governance/Governable.sol
match contracts/governance/Strategizable.sol
match contracts/interfaces/cctp/ICCTP.sol
match contracts/interfaces/IBasicToken.sol
match contracts/interfaces/IMerkl.sol
match contracts/interfaces/IStrategy.sol
match contracts/interfaces/IVault.sol
match contracts/interfaces/morpho/IMorphoV2Adapter.sol
match contracts/interfaces/morpho/IVaultV2.sol
match contracts/strategies/crosschain/AbstractCCTPIntegrator.sol
match contracts/strategies/crosschain/CrossChainRemoteStrategy.sol
match contracts/strategies/crosschain/CrossChainStrategyHelper.sol
match contracts/strategies/Generalized4626Strategy.sol
match contracts/strategies/MorphoV2VaultUtils.sol
match contracts/token/OUSD.sol
match contracts/utils/BytesHelper.sol
match contracts/utils/Helpers.sol
match contracts/utils/Initializable.sol
match contracts/utils/InitializableAbstractStrategy.sol
match contracts/vault/VaultStorage.sol
match lib/openzeppelin/interfaces/IERC4626.sol
There was a problem hiding this comment.
- All deployed contracts are listed in the deploy PR's description
- Deployed contract's verified code (and all dependencies) match the code in master
- Contract constructors have correct arguments
- The transactions that interacted with the newly deployed contract match the deploy script.
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2830 +/- ##
=======================================
Coverage 41.10% 41.10%
=======================================
Files 110 110
Lines 4634 4634
Branches 1263 1263
=======================================
Hits 1905 1905
Misses 2726 2726
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Deploy 46
Deployed contracts:
Deployed contracts
Deploy checklist
Two reviewers complete the following checklist: