Fix facter networking on OpenBSD with gif or gre tunnel interfaces#60
Open
buzzdeee wants to merge 2 commits intoOpenVoxProject:mainfrom
Open
Fix facter networking on OpenBSD with gif or gre tunnel interfaces#60buzzdeee wants to merge 2 commits intoOpenVoxProject:mainfrom
buzzdeee wants to merge 2 commits intoOpenVoxProject:mainfrom
Conversation
interface configured.
Contributor
|
I think |
Contributor
Can you elaborate, please? For gif/gre? For tunnel interfaces, e.g. incl. tun? At all? Why (not)?
I do have code that using them to
(Interesting to see that your bindings lack the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when there's a gif or gre tunnel interface configured, issue happens.
Today I updated a way out of date box, which prior to update ran puppet and facter.
Now with openfact, it broke, with a tunnel interface like this:
the 192.168.178.21 is the IP of my egress device, and there is properly shows up as binding, but it's right to not show up here as binding.
when running facter networking, causes errors and output like:
With patch below, facter networking.interfaces.gif0 looks like this:
Issue seen with openfact 5.2.0 and 5.2.1.
No idea if the fix is the right approach, any feedback appreciated