MIDI File Fixes for Technical Errors#24
Open
curioustorvald wants to merge 3 commits intoOpenTTD:masterfrom
Open
MIDI File Fixes for Technical Errors#24curioustorvald wants to merge 3 commits intoOpenTTD:masterfrom
curioustorvald wants to merge 3 commits intoOpenTTD:masterfrom
Conversation
…ges back, which causes other songs to play distorted
…ouldn't distort even if the player skips a song while playing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #17
This commit fixes so-called "music is distorted but sometimes" bug observed on Windows, caused by some songs changing MIDI Pitch Bend ranges but it's not being reverted.
In other words, I just added bend range reset commands on every single MIDI file so that they are properly initialised.
Ideally this should be fixed by the sequencer itself — they should reset any parameter changes from previous songs — but it seems Windows MIDI sequencer doesn't do that, and since Microsoft actually fixing any music-related bugs on their product is simply something that would never happen, I thought it would be better to "fix" the MIDI file themselves.