reference legacy GHA internal call like external#111
Conversation
Tags
|
There was a problem hiding this comment.
Pull request overview
Updates the Terraform validate/plan “env roots” reusable workflow to call the legacy-stable reusable workflow via a fully-qualified owner/repo@ref reference (mirroring how external consumers reference it), and includes a package-lock.json refresh that bumps several transitive dependencies.
Changes:
- Switch
.github/workflows/tf_validate_plan_env_roots.ymlfrom a local reusable workflow reference toOpenSesame/core-github-actions/...@legacy-stable. - Refresh
package-lock.json, bumping transitive packages (e.g.,minimatch,ajv,brace-expansion) and removing some"peer": truemarkers.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/tf_validate_plan_env_roots.yml |
Points the env-roots workflow to the legacy-stable reusable workflow via external-style reference. |
package-lock.json |
Updates transitive dependency versions/metadata as part of a lockfile regeneration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| TF-Validate-Plan-Roots: | ||
| name: TF Validate/Plan ENV Roots | ||
| uses: ./.github/workflows/tf_validate_plan_single_root.yml | ||
| uses: OpenSesame/core-github-actions/.github/workflows/tf_validate_plan_single_root.yml@legacy-stable | ||
| strategy: | ||
| fail-fast: false # continues to run jobs even if one fails |
There was a problem hiding this comment.
This job now calls a reusable workflow via uses: but the workflow doesn't declare permissions. Other callers (e.g., .github/workflows/deploy_environment.yml) explicitly grant id-token: write for the Terraform plan workflow; without equivalent permissions here, the called workflow may not be able to request an OIDC token (common failure when using aws-actions/configure-aws-credentials). Consider adding an explicit permissions block (at least id-token: write and contents: read) to this workflow or to the TF-Validate-Plan-Roots job so token permissions are well-defined for downstream callers.
PR Summary
Jira: https://opensesame.atlassian.net/browse/CORE-XXXX
Description of Changes
Versioning
Versioned components live under
./github/actionsDoes this PR modify a versioned component?
version:untrackedversion:<component-name>/X.Y.ZCHANGELOG.mdincludes a## X.Y.Zentryversion:untrackedonly if changes do not alter behavior, inputs, or outputsIf version labels are incorrect or missing, automated version validation will fail and block merge.
Dependencies of PR
Testing