Open
Conversation
…s as an input, to remove RPM as an input completely, since this input has no effect on the motor mass calculation, which is the purpose of motor premission
…ary_options because no longer needed
…ion input instead, rephrased Aircraft.Engine.SCALE_FACTOR to remove reference to the unit that is being scaled (thrust) because electric motors will probably be scaled based on torque
… as options input to motor mission and premission. updated tests to set aviary_values and motor file location before running tests
…ly started with "Using External Subsystems".
…electric motor to the same subsection
…and test_motor_premission
… option error on test_turboprop_model test 4
Got some tests passsing for new motor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New metadata entry to handle electric motor maps
Aircraft.Engine.Motor.DATA_FILE.User can now set
Aircraft.Engine.Motor.DATA_FILEthrough Aviary options to specify which map file to use.1 map .csv broken out of motor_mapy.py now included by default in repo
Unit specification for Motor map is now specified in the map.csv file and units from there are imported and set properly
Removed map extrapolation to prevent issues where efficiency would go over 100% due to off-map exploration
Reworded definition of
Aircraft.Engine.SCALE_FACTORso it is not exclusive for turbine engines (they scale based on thrust)Aircraft.Engine.SCALE_FACTORis still used but scales based on Torque and docs reflect thisAdd doc page for Motor
Added note that overrides do not work for the motor subsystem
Reworked the model option processor so that we also remove the "brackets" when setting options on single-engine models. We were getting lucky in that the handful of options that were inadvertently kept as lists didn't break any calculations.
Adjusted the turboprop_model unit test to be more like an Aviary model so that the model options glob patterns find the engine components.
Title change in Docs for "Using External Subsystems" to "External Subsystems" for clarity
Related Issues
Backwards incompatibilities
None
New Dependencies
None