Two-dof refactor part 4: Replaced remaining two-dof phases/odes/eoms with more general phase builders selectable with PhaseType.#1000
Open
Kenneth-T-Moore wants to merge 20 commits intoOpenMDAO:mainfrom
Open
Conversation
…ed_two_dof directories
jkirk5
reviewed
Mar 2, 2026
Contributor
jkirk5
left a comment
jkirk5
left a comment
There was a problem hiding this comment.
Should "phase_builder" phase_info option get added to the option dictionaries for the phases? Or am I missing that?
Also I will suggest using phase_type instead of phase_builder in the phase info user options because it doesn't accept a PhaseBuilder
Member
Author
It lives in the base class for the phase builder dictionariess.
Good idea, i will make that change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #986 should be reviewed and merged first.
New PhaseType
TWO_DOF_TAKEOFFadded.New PhaseType
ACCELadded.Updated all existing phase-infos accordingly.
Moved the old two dof GroundPhase, ode, and eom over to the Solved Two-dof section, since they were also re-used there.
Related Issues
Backwards incompatibilities
None
New Dependencies
None