Fix/issue #6/point updates are not reflected#335
Open
elof-dev wants to merge 5 commits intoOpenClassrooms-Student-Center:masterfrom
Open
Fix/issue #6/point updates are not reflected#335elof-dev wants to merge 5 commits intoOpenClassrooms-Student-Center:masterfrom
elof-dev wants to merge 5 commits intoOpenClassrooms-Student-Center:masterfrom
Conversation
- Updated showSummary() in server.py to handle email validation and error messages - Modified index.html to display flash messages correctly - Created tests/ folder with conftest.py and test_show_summary.py for unit testing - Added .flaskenv for local environment configuration - Updated .gitignore to include .venv and exclude tests/ folder - Updated requirements.txt to add pytest dependency
- Updated purchasePlaces() to check if the club has enough points before confirming a booking - Added a new test file with 2 unit tests to verify point validation logic
- Updated purchasePlaces() to check avoid clubs booking more than 12 places per competition - Added a new test file with 2 unit tests to verify point validation logic
- Updated book() to avoid clubs booking in past competition - Added a new test file with 2 unit tests
- Added missing line in purchasePlaces() to decrease club points after a valid booking - Created test to verify: - club points decrease when booking succeeds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes **Issue #6 ** — club points were not being updated after a booking
Context
Previously, when a club booked places, the number of competition places was updated but the club's own points remained unchanged.
Changes Made
club['points'] = club_points - placesRequiredinpurchasePlaces()Testing
pytestLinked Issue
Fix #6