Fix issue #1 : Entering an unknown email crashes the app#331
Open
elof-dev wants to merge 1 commit intoOpenClassrooms-Student-Center:masterfrom
Open
Conversation
- Updated showSummary() in server.py to handle email validation and error messages - Modified index.html to display flash messages correctly - Created tests/ folder with conftest.py and test_show_summary.py for unit testing - Added .flaskenv for local environment configuration - Updated .gitignore to include .venv and exclude tests/ folder - Updated requirements.txt to add pytest dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes Issue #1 – the application crashed when entering an unknown email on the login page.
Context
The function
showSummary()inserver.pydid not properly handle invalid or unknown emails.This caused the app to fail instead of displaying an appropriate flash message to the user.
Changes Made
showSummary()logic to handle email validation and unknown usersconftest.pyfor Flask test configurationtest_show_summary.pyto testshowSummary()behavior with valid/invalid emails.venvand keepstests/includedpytestdependencyTesting
pytestLinked Issue
Fixes #1