Open
Conversation
concatime
force-pushed
the
musl-support
branch
from
6a36f47 to
8794c04
Compare
kraj
requested changes
Nov 4, 2021
Collaborator
kraj
left a comment
kraj
left a comment
There was a problem hiding this comment.
I dont see these patches being applied via chromium-gn.inc so how are they supposed to work?
secondly, I am still bewildered on how to reproduce the failures you are seeing. There much be something thats different in your environment that I am not seeing here. Since build succeeds without these patches for me.
concatime
force-pushed
the
musl-support
branch
from
8794c04 to
367cd6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #578.