Skip to content

Fix update of bytes read in the encoder state machine. #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
orium wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix update of bytes read in the encoder state machine. #456

orium wants to merge 2 commits into from
+85 −14

Conversation

@orium
Copy link
Contributor

@orium orium commented Feb 11, 2026 •
edited
Loading

Previously we were not updating the number of bytes read: we were just changing the local binding of read. This means that read was always zero and therefore the encoder never flushed.

Fixes #455

@orium orium force-pushed the fix-flush-encoder branch from 494f082 to 5996a6f Compare February 11, 2026 16:12
@orium
Copy link
Contributor Author

orium commented Feb 11, 2026

I'll try to add a test for this. Right now I'm investigating the failing tests.

@orium
Copy link
Contributor Author

orium commented Feb 11, 2026 •
edited
Loading

I'll try to add a test for this. Right now I'm investigating the failing tests.

This seems to be another bug introduced in 8947fed. I've reverted that commit in this PR (first commit). I think the bug is that we were turning some Poll::Pending into Poll::Ready(Ok(0)) signaling an EOF when there's actually more data to read.

@orium orium changed the title Fix update of bytes read in the encoder state machine. [WIP!] Fix update of bytes read in the encoder state machine. Feb 11, 2026
@orium orium changed the title [WIP!] Fix update of bytes read in the encoder state machine. [WIP] Fix update of bytes read in the encoder state machine. Feb 11, 2026
@orium orium marked this pull request as draft February 11, 2026 18:02
@orium orium changed the title [WIP] Fix update of bytes read in the encoder state machine. Fix update of bytes read in the encoder state machine. Feb 11, 2026
orium added 2 commits February 12, 2026 16:01
@orium
Revert "Refactor bufread::decoder: Extract poll ready check (Nullus…
1b05474 
…157#418)"

This reverts commit 8947fed.

This introduced a bug. I think it's because we turn some `Poll::Pending` into
`Poll::Ready(Ok(0))` signaling an EOF when there's actually more data to read.
@orium
Fix update of bytes read in the encoder state machine.
2954200 
Previously we were not updating the number of bytes read: we were just changing
the local binding of `read`. This means that read was always zero and therefore
the encoder never flushed.

Fixes Nullus157#455.
@orium orium force-pushed the fix-flush-encoder branch from 4ed8167 to 2954200 Compare February 12, 2026 16:02
@orium orium marked this pull request as ready for review February 12, 2026 16:06
@orium orium mentioned this pull request Feb 12, 2026
Open
@orium
Copy link
Contributor Author

orium commented Feb 12, 2026

@NobodyXu This should be ready for review now.

@orium orium mentioned this pull request Feb 12, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The encoder is never flushing

1 participant

@orium