Open
Conversation
faran4engg
reviewed
Oct 27, 2021
| <Route path="/add-expense" exact component={AddExpense} /> | ||
| </Switch> | ||
| <Footer /> | ||
| </BrowserRouter> |
faran4engg
reviewed
Oct 27, 2021
| display: flex; | ||
| flex-direction: column; | ||
| flex: 1; | ||
| height: 60vh; |
Contributor
There was a problem hiding this comment.
group the css
cc: @coder-mezab , @Tanvir04khan , @Tauqeer-Ahmed-99
faran4engg
reviewed
Oct 27, 2021
| const handleSubmit = () => { | ||
| if (title === "" || amount === "" || !category) { | ||
| const notify = () => toast("Please enter complete data"); | ||
| notify(); |
Contributor
There was a problem hiding this comment.
cant we directly call toast("Please enter complete data");
faran4engg
reviewed
Oct 27, 2021
| <input | ||
| placeholder="Give a name to your expenditure" | ||
| value={title} | ||
| onChange={(e) => handleTitle(e)} |
Contributor
There was a problem hiding this comment.
Suggested change
| onChange={(e) => handleTitle(e)} | |
| onChange={handleTitle} |
faran4engg
reviewed
Oct 27, 2021
| <input | ||
| placeholder="Enter Amount" | ||
| className="amount-input" | ||
| onChange={(e) => handleAmount(e)} |
Contributor
There was a problem hiding this comment.
Suggested change
| onChange={(e) => handleAmount(e)} | |
| onChange={handleAmount} |
faran4engg
reviewed
Oct 27, 2021
| <div className="modal-inner"> | ||
| <label>Expense Added Successfully</label> | ||
| <img | ||
| src={require("../../assets/images/added-image.png").default} |
Contributor
There was a problem hiding this comment.
why cant u import it above
faran4engg
reviewed
Oct 27, 2021
| import React from "react"; | ||
| import "./footer.css"; | ||
|
|
||
| const Footer = () => { |
Contributor
There was a problem hiding this comment.
single statement.. implicit return ?
faran4engg
reviewed
Oct 27, 2021
Contributor
faran4engg
left a comment
faran4engg
left a comment
There was a problem hiding this comment.
Very dufficult to review poorly formatted code. Next time if its like this, No one would review !!
faran4engg
reviewed
Oct 30, 2021
Contributor
faran4engg
left a comment
faran4engg
left a comment
There was a problem hiding this comment.
update ?? @rifaq-ahmer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed the React Practice Project called Expense Tracker with React having redux for state management and React Routing.
in addition to this, I have used react notify, and react modal npm package.