This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(tags): adds props for validation for required and exclusive tags#6177
Merged
fix(tags): adds props for validation for required and exclusive tags#6177
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the TagPicker component's validation flexibility by introducing configurable validation for required and exclusive tags. The changes decouple tag validation logic from the component's hardcoded behavior, allowing different contexts to apply appropriate validation rules.
- Added
validateRequiredTagsandvalidateExclusiveTagsprops to control validation behavior - Required tag validation is disabled by default and enabled only for incident/case reports and detail forms
- Exclusive tag validation remains enabled by default but is disabled for filter and search modals
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/dispatch/static/dispatch/src/tag/TagPicker.vue | Core component changes adding validation props and conditional logic |
| src/dispatch/static/dispatch/src/signal/NewEditDialog.vue | Enables required tag validation for signal editing |
| src/dispatch/static/dispatch/src/search/SearchFilterCreateDialog.vue | Disables exclusive tag validation for search filters |
| src/dispatch/static/dispatch/src/incident_role/PolicyRoleBuilder.vue | Disables exclusive tag validation for policy role configuration |
| src/dispatch/static/dispatch/src/incident/TableFilterDialog.vue | Disables exclusive tag validation for incident table filters |
| src/dispatch/static/dispatch/src/incident/TableExportDialog.vue | Disables exclusive tag validation for incident export |
| src/dispatch/static/dispatch/src/incident/ReportSubmissionForm.vue | Enables required tag validation for incident reporting |
| src/dispatch/static/dispatch/src/incident/ReportSubmissionCard.vue | Enables required tag validation for incident submission |
| src/dispatch/static/dispatch/src/incident/DetailsTab.vue | Enables required tag validation for incident details |
| src/dispatch/static/dispatch/src/data/source/TableFilterDialog.vue | Disables exclusive tag validation for source table filters |
| src/dispatch/static/dispatch/src/data/source/EditBasicInfoTab.vue | Enables required tag validation for source editing |
| src/dispatch/static/dispatch/src/data/query/TableFilterDialog.vue | Disables exclusive tag validation for query table filters |
| src/dispatch/static/dispatch/src/data/query/EditBasicInfoTab.vue | Enables required tag validation for query editing |
| src/dispatch/static/dispatch/src/dashboard/incident/IncidentDialogFilter.vue | Disables exclusive tag validation for dashboard incident filters |
| src/dispatch/static/dispatch/src/dashboard/case/CaseDialogFilter.vue | Disables exclusive tag validation for dashboard case filters |
| src/dispatch/static/dispatch/src/case/TableFilterDialog.vue | Disables exclusive tag validation for case table filters |
| src/dispatch/static/dispatch/src/case/TableExportDialog.vue | Disables exclusive tag validation for case export |
| src/dispatch/static/dispatch/src/case/DetailsTab.vue | Enables required tag validation for case details |
aaronherman
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the
TagPickercomponent's validation flexibility by introducing configurable validation for required and exclusive tags. The changes decouple tag validation logic from the component's hardcoded behavior, allowing different contexts to apply appropriate validation rules.validateRequiredTagsandvalidateExclusiveTagsprops to control validation behavior