fix: update config.example and scripts for kubespray v2.30 group names#1340
Merged
michael-balint merged 1 commit intoNVIDIA:masterfrom Feb 20, 2026
Merged
Conversation
Follow-up to PR NVIDIA#1336: rename remaining kube-master references to kube_control_plane and k8s-cluster to k8s_cluster in config.example group_vars, example playbook, and helper scripts (debug.sh, deploy_rook.sh). Also update ssh-hardening collection reference (dev-sec.ssh-hardening -> devsec.hardening) in config.example/group_vars/all.yml. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Douglas Holt <dholt@nvidia.com>
There was a problem hiding this comment.
Pull request overview
This PR completes the kubespray v2.30 group naming migration started in PR #1336 by updating remaining references in configuration examples, helper scripts, and comments.
Changes:
- Renamed inventory group references from old kubespray v2.27 naming (kube-master → kube_control_plane, kube-node → kube_node, k8s-cluster → k8s_cluster)
- Updated SSH hardening collection reference in comment (dev-sec.ssh-hardening → devsec.hardening)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/k8s/deploy_rook.sh | Updated ansible group reference from k8s-cluster to k8s_cluster in delete_rook function |
| scripts/k8s/debug.sh | Updated comment and ansible group references from kube-node to kube_node throughout debug script |
| config.example/playbooks/example.yml | Updated example playbook host declaration from kube-node to kube_node |
| config.example/group_vars/k8s_cluster.yml | Updated Jinja2 template group references from kube-master to kube_control_plane and k8s-cluster to k8s_cluster |
| config.example/group_vars/all.yml | Updated comments from dev-sec.ssh-hardening to devsec.hardening and k8s-cluster to k8s_cluster |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
michael-balint
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kube-masterreferences tokube_control_planeandk8s-clustertok8s_clusterin config.example group_vars, example playbook, and helper scripts.dev-sec.ssh-hardening->devsec.hardening) inconfig.example/group_vars/all.yml.Test plan
ansible-playbook playbooks/k8s-cluster.ymlruns successfully with updated configscripts/k8s/debug.shreferences correct group namesscripts/k8s/deploy_rook.shreferences correct group names🤖 Generated with Claude Code