Merged
Conversation
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
mdboom
added
test
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
rwgk
approved these changes
Mar 5, 2026
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 12.9.x
git worktree add -d .worktree/backport-1727-to-12.9.x origin/12.9.x
cd .worktree/backport-1727-to-12.9.x
git switch --create backport-1727-to-12.9.x
git cherry-pick -x 637e4eb7d76f9f090bc86ab74b5df34b8ee4cb1e |
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses two failing tests reported in nvbug 5880275. Both of these tests are skipped in our CI due to not having the appropriate NvLink hardware, so were only caught by QA.
One test is simply a typo (exacerbated by the fact that the capitalization of
Nvlinkin the originalnvml.his inconsistent).The other test was ported from the upstream NVML test suite, which accepted a NULL pointer as the input. The new NVML bindings don't accept NULLs, so this test is basically invalid over here, so it's removed.