Open
Conversation
Signed-off-by: Eric Pham-Hung <ephamhung@ephamhung-mlt.client.nvidia.com>
Signed-off-by: Eric Pham-Hung <ephamhung@nvidia.com>
Signed-off-by: Eric Pham-Hung <ephamhung@nvidia.com>
nina-xu
reviewed
Nov 5, 2025
nina-xu
left a comment
nina-xu
left a comment
There was a problem hiding this comment.
overall it looks good! thanks so much for putting this together
| "id": "630e3e17", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "# 🎛️ NeMo Safe Synthesizer 101: Extrinsic Evaluation\n", |
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "# This script defines a scikit-learn pipeline for a classification task.\n", |
There was a problem hiding this comment.
For the extrinsic evaluation portion, there’s a bit of code repetition. Suggest to DRY it up by defining the train + eval steps into a function, and call that function twice with train_and_evaluate_logistic_regression(df, test_df); train_and_evaluate_logistic_regression(synthetic_df, test_df). This also makes it very clear to a user what we are doing here.
| "from sklearn.metrics import classification_report, accuracy_score, roc_auc_score\n", | ||
| "\n", | ||
| "original_pipeline = full_pipeline \n", | ||
| "print(\"\\n--- Training Benchmark Model on Original Data (1000 rows) ---\")\n", |
There was a problem hiding this comment.
I don't think the 1000 here is accurate here?
Comment on lines
+467
to
+470
| "| Accuracy | 0.9404 | 0.9278 |\n", | ||
| "| ROC AUC Score | 0.9782 | 0.9762 |\n", | ||
| "| Precision (Class 1) | 0.9626 | 0.9423 |\n", | ||
| "| Recall (Class 1) | 0.9646 | 0.9714 |\n", |
There was a problem hiding this comment.
This is amazing results. out of curiorsity what was the SQS?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.