Skip to content

Comments

Remove a deprecated/invalid argument#5913

Merged
wujingyue merged 2 commits intomainfrom
wjy/tidy
Feb 20, 2026
Merged

Remove a deprecated/invalid argument#5913
wujingyue merged 2 commits intomainfrom
wjy/tidy

Conversation

@wujingyue
Copy link
Collaborator

E[22:55:14.740] tidy-config error at /opt/pytorch/nvfuser/.clang-tidy:50:0: unknown key 'AnalyzeTemporaryDtors'

```
E[22:55:14.740] tidy-config error at /opt/pytorch/nvfuser/.clang-tidy:50:0: unknown key 'AnalyzeTemporaryDtors'
```
@wujingyue wujingyue requested a review from xwang233 February 3, 2026 07:21
@wujingyue
Copy link
Collaborator Author

!build

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Review updated until commit 4e2d231

Description

  • Remove invalid AnalyzeTemporaryDtors configuration from .clang-tidy

  • Fix tidy-config error: unknown key 'AnalyzeTemporaryDtors'

  • Clean up deprecated clang-tidy argument

Changes walkthrough

Relevant files
Bug fix
.clang-tidy
Remove invalid AnalyzeTemporaryDtors configuration             

.clang-tidy

  • Removed invalid AnalyzeTemporaryDtors: false configuration line
  • Fixed clang-tidy configuration error
  • +0/-1     

    PR Reviewer Guide

    Here are some key observations to aid the review process:

    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @greptile-apps
    Copy link
    Contributor

    greptile-apps bot commented Feb 3, 2026

    Greptile Summary

    This PR removes the deprecated AnalyzeTemporaryDtors configuration option from the .clang-tidy file, which was causing an "unknown key" error during clang-tidy execution.

    Changes:

    • Removed the line AnalyzeTemporaryDtors: false from .clang-tidy configuration

    Assessment:
    The AnalyzeTemporaryDtors option was part of the clang Static Analyzer and has been removed in newer versions of clang-tidy. This is a straightforward configuration cleanup that resolves the error message mentioned in the PR description.

    Confidence Score: 5/5

    • This PR is safe to merge with no risk
    • The change is a simple configuration file cleanup that removes a deprecated option causing errors. It's a single-line deletion with no impact on code behavior, only fixes a configuration error.
    • No files require special attention

    Important Files Changed

    Filename Overview
    .clang-tidy Removed deprecated AnalyzeTemporaryDtors option that was causing configuration errors

    Last reviewed commit: 4e2d231

    Copy link
    Contributor

    @greptile-apps greptile-apps bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    1 file reviewed, no comments

    Edit Code Review Agent Settings | Greptile

    @wujingyue
    Copy link
    Collaborator Author

    Gentle ping, @xwang233

    @wujingyue
    Copy link
    Collaborator Author

    !build

    Copy link
    Contributor

    @greptile-apps greptile-apps bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    1 file reviewed, no comments

    Edit Code Review Agent Settings | Greptile

    @wujingyue wujingyue merged commit db02071 into main Feb 20, 2026
    19 checks passed
    @wujingyue wujingyue deleted the wjy/tidy branch February 20, 2026 02:05
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants