Conversation
padraic-shafer
requested changes
Jun 26, 2024
Contributor
padraic-shafer
left a comment
padraic-shafer
left a comment
There was a problem hiding this comment.
Overall this looks very good. I've included a few suggestions, and I think I spotted a logic error in the rotation sense used by da.rotate90().
Co-authored-by: Padraic Shafer <76011594+padraic-shafer@users.noreply.github.com>
Contributor
Author
|
Ah good catch! Thanks! |
Contributor
|
@ambarb This is ready for review + merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Dask versions of the C functions
fastccd::correct_fccd_imagesandimage::rotate90.This should enable us to do all of the modifications for loading in chunks, and grab 1 chunk at a time from tiled to load. The C functions are parallelized; however, they need to load the full arrays into RAM.