Wcs handle errors#150
Open
gbburkhardt wants to merge 7 commits intoNASAWorldWind:developfrom
gbburkhardt:WCS-handle-errors
Open
Wcs handle errors#150gbburkhardt wants to merge 7 commits intoNASAWorldWind:developfrom gbburkhardt:WCS-handle-errors
gbburkhardt wants to merge 7 commits intoNASAWorldWind:developfrom
gbburkhardt:WCS-handle-errors
Conversation
case for file extension
case for file extension
… has for the layer, or the request may fail. See https://forum.worldwindcentral.com/forum/world-wind-java-forums/development-help/158241-wcs-elevation-model-with-partial-data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Why Should This Be In Core?
Bugs, of course, should be fixed. Memory/resource leaks are "bad". I added the error checks when I was debugging my setup of a WCS server for elevation data. They are likely to help others.
Benefits
more robust code
Potential Drawbacks
I was a bit concerned of the effect clipping the tile size to what's in the server would have on other code in the system. As far as I could tell, the ElevationModel correctly handles missing data, and if a request is made for data outside the clipped tile, the next ElevationModel in the list will be checked.
Applicable Issues
None that I know of...