Phase 3.2: Convert critter-core main sources from Kotlin to Java#4197
Open
evanchooly wants to merge 1 commit intomasterfrom
Open
Phase 3.2: Convert critter-core main sources from Kotlin to Java#4197evanchooly wants to merge 1 commit intomasterfrom
evanchooly wants to merge 1 commit intomasterfrom
Conversation
- Convert all 20 Kotlin production files in critter/core/src/main/kotlin/ to Java equivalents - Remove Kotlin stdlib, kotlin-reflect, and KSP dependencies from critter-core pom.xml - Disable Kotlin maven plugin for critter-core (no longer has Kotlin sources) - Update build-plugins generator (AnnotationNodeExtensions.kt) to produce Java instead of Kotlin, eliminating the generated Kotlin file and associated compilation requirement - Update critter-maven CritterProcessor.kt to use new Java singleton API (INSTANCE pattern) - Update test files to use static Java methods instead of Kotlin companion/file-level functions - All 57 critter-core tests and 11 integration tests pass Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
critter/core/src/main/kotlin/to Java equivalentskotlin-stdlib,kotlin-reflect, and KSP dependencies fromcritter-corepom.xmlbuild-pluginsgenerator (AnnotationNodeExtensions.kt) to produce a.javafile instead of.kt, eliminating the need for Kotlin compilation of generated sourcescritter-maven'sCritterProcessor.ktto use the new Java singleton API (INSTANCEpattern)Key conversion patterns used
objectsingletons → Java class withpublic static final INSTANCEfieldby lazy→ null-check lazy initializationuse {}/apply {}scope functions → try-with-resources / sequential calls::class→.classfor JavaClass<?>referencesTest plan
Closes part of #4186 (Phase 3: Move critter-core into morphia-core)
🤖 Generated with Claude Code