Phase 3.1: Convert critter-core test sources from Kotlin to Java#4196
Merged
evanchooly merged 1 commit intomasterfrom Mar 1, 2026
Merged
Phase 3.1: Convert critter-core test sources from Kotlin to Java#4196evanchooly merged 1 commit intomasterfrom
evanchooly merged 1 commit intomasterfrom
Conversation
Replaces all 9 Kotlin test files under critter/core/src/test/kotlin/
with equivalent Java implementations. The Kotlin production code is
unchanged; all tests compile and pass against it (57 tests, 0 failures).
Converted files:
- ClassfileOutput.kt → ClassfileOutput.java
- parser/BaseCritterTest.kt → parser/BaseCritterTest.java
- parser/GeneratorTest.kt → parser/GeneratorTest.java
- parser/TestAccessorsMutators.kt → parser/TestAccessorsMutators.java
- parser/TestEntityModelGenerator.kt → parser/TestEntityModelGenerator.java
- parser/TestPropertyModelGenerator.kt → parser/TestPropertyModelGenerator.java
- parser/TestVarHandleAccessor.kt → parser/TestVarHandleAccessor.java
- parser/TypesTest.kt → parser/TypesTest.java
- parser/gizmo/TestGizmoGeneration.kt → parser/gizmo/TestGizmoGeneration.java
Key conversion patterns applied:
- Kotlin object singletons → Java static classes
- Extension functions → static helper methods
- Kotlin object API → INSTANCE access (Generators.INSTANCE, CritterGizmoGenerator.INSTANCE)
- Kotlin top-level funs → *Kt class static methods (CritterKt, PropertyModelGeneratorKt, GizmoExtensionsKt)
- Companion object methods → Companion access (Critter.Companion.critterPackage)
- scan().use {} → try-with-resources
- Lambda collections → Java streams
Closes task 3.1 of Phase 3 (#4195).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
critter/core/src/test/kotlin/to equivalent JavaKey conversion patterns
object GeneratorsGenerators.INSTANCE.method()Critter.Companion.critterPackage()Critter.Companion.critterPackage()str.titleCase()CritterKt.titleCase(str)typeData(str)(top-level)PropertyModelGeneratorKt.typeData(str, classLoader)node.annotationBuilder(mc)GizmoExtensionsKt.annotationBuilder(node, mc)closeable.use { }Type.asClass()extensionGenerators.INSTANCE.asClass(type, classLoader)Test plan
./mvnw test -pl :critter-core— 57 tests, 0 failures, 0 errors./mvnw spotless:apply -pl :critter-core— formatting appliedCloses task 3.1 of Phase 3 (#4195).
🤖 Generated with Claude Code