Skip to content

fix：Improve filter synchronization and data fetching in SearchControls #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dallas98 merged 1 commit into from
Mar 2, 2026
Merged

fix：Improve filter synchronization and data fetching in SearchControls #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions frontend/src/components/SearchControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ export function SearchControls({
} else {
// 非受控模式：更新内部状态
setInternalSelectedFilters(newFilters);
// 同时通知父组件当前的筛选值，避免依赖 useEffect 造成死循环
onFiltersChange?.(newFilters);
}
};

Expand Down Expand Up @@ -140,20 +142,6 @@ export function SearchControls({
(values) => Array.isArray(values) && values.length > 0 && values[0] !== undefined
);

// 同步外部 selectedFilters 到内部状态
useEffect(() => {
if (externalSelectedFilters !== undefined) {
setInternalSelectedFilters(externalSelectedFilters);
}
}, [externalSelectedFilters]);

// 非受控模式下，当内部状态变化时通知父组件
useEffect(() => {
if (externalSelectedFilters !== undefined) return; // 受控模式不需要这个 effect
if (Object.keys(selectedFilters).length === 0) return;
onFiltersChange?.(selectedFilters);
}, [selectedFilters, onFiltersChange, externalSelectedFilters]);

return (
<div className={className}>
<div className="flex items-center justify-between gap-8">
Expand Down
Loading
Loading