Conversation
Signed-off-by: thelooter <evekolb2204@gmail.com>
Signed-off-by: thelooter <evekolb2204@gmail.com>
Deploying web with
|
| Latest commit: |
ea475f4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8e8fdf5f.web-9b9.pages.dev |
| Branch Preview URL: | https://chore-major-upgrade.web-9b9.pages.dev |
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the project from Nuxt 3 to Nuxt 4, which represents a major framework upgrade with significant dependency updates and new application code.
Key Changes:
- Upgraded Nuxt from v3.19.3 to v4.2.1
- Updated FontAwesome packages from v6.7.2 to v7.1.0 (major version bump)
- Updated VueUse from v12.8.2 to v14.0.0 (major version bump)
- Updated ESLint and related plugins to newer versions
- Added Node.js engine requirements
- Added new pages (team, privacy, legal, cookies, index, error)
- Added new components (NavBar, Footer, Team, Highlight, Catch sections)
- Added FontAwesome plugin configuration
Reviewed changes
Copilot reviewed 2 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated all major dependencies for Nuxt 4 compatibility, added Node.js engine requirements |
| pnpm-lock.yaml | Lockfile reflecting all dependency updates and version resolutions |
| eslint.config.js | Minor path adjustment for ESLint config import |
| app/plugins/fontawesome.ts | New plugin to configure FontAwesome icons globally |
| app/pages/*.vue | New page components for team, privacy, legal, cookies, index, and error pages |
| app/components/*.vue | New reusable components for navigation, footer, and content sections |
| app/layouts/default.vue | New default layout wrapper |
| app/assets/* | New CSS and image assets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import pluginJs from "@eslint/js"; | ||
| import eslintPluginPrettierRecommended from "eslint-plugin-prettier/recommended"; | ||
| import withNuxt from "./.nuxt/eslint.config.mjs"; | ||
| import withNuxt from ".nuxt/eslint.config.mjs"; |
There was a problem hiding this comment.
[nitpick] The import path has been changed from ./.nuxt/eslint.config.mjs to .nuxt/eslint.config.mjs. While both paths should work in most cases, the ./ prefix is more explicit and is a common best practice for relative imports. However, this change is likely intentional as part of the Nuxt 4 upgrade and should work correctly.
| import withNuxt from ".nuxt/eslint.config.mjs"; | |
| import withNuxt from "./.nuxt/eslint.config.mjs"; |
| "packageManager": "pnpm@10.23.0" | ||
| "packageManager": "pnpm@10.23.0", | ||
| "engines": { | ||
| "node": "^22 || ^24 || ^25" |
There was a problem hiding this comment.
The node engine requirement has been added as "^22 || ^24 || ^25". However, Nuxt 4 officially requires Node.js version ^20.19.0 or >=22.12.0 according to the lock file changes. The specified range excludes Node 20 and 23, which may cause issues for users on those versions. Consider using "^20.19.0 || >=22.12.0" to align with Nuxt 4's requirements.
| "node": "^22 || ^24 || ^25" | |
| "node": "^20.19.0 || >=22.12.0" |
|
There are some suggestions from the bot and the linting is failing |
2 participants
No description provided.