Conversation
…time to runtime-liberty
mattbsox
force-pushed
the
runtimesWithParameters
branch
from
22f7863 to
b1fd41a
Compare
|
Seems to cover issue #341 |
|
Need some reviews. Thanks! @chyt @scottkurz @cherylking @ajm01 @awisniew90 @uberskigeek |
| String runtime = System.getProperty('runtime') | ||
|
|
||
| if (libertyRuntime == null || libertyRuntime.isEmpty()) { | ||
| if (runtime == null || runtime.isEmpty()) { |
There was a problem hiding this comment.
The exception explicitly states they need to specify a Liberty runtime. Should it be more generic? Same for the runtimeVersion check below.
There was a problem hiding this comment.
Ah yup, I'll change these to be boost specific.
| } else { | ||
| runtimeGroup = "com.ibm.websphere.appserver.runtime" | ||
| runtimeArtifactId = "wlp-javaee7" | ||
| if (runtime == "ol") { |
There was a problem hiding this comment.
How do other runtimes get handled? Not understanding why we do something for "ol" specifically here.
| project.dependencies.add('libertyRuntime', "io.openliberty:openliberty-runtime:$OPEN_LIBERTY_VERSION") | ||
| } | ||
| } | ||
| // project.liberty.server = configureBoostServerProperties() |
There was a problem hiding this comment.
Should this commented out code be deleted?
| import boost.common.boosters.AbstractBoosterConfig; | ||
| import boost.common.config.BoosterConfigurator | ||
| import boost.common.config.BoostProperties; | ||
| import boost.common.utils.BoostUtil |
There was a problem hiding this comment.
The description on line 49 mentions Liberty. Should it? It depends on the specified runtime right?
| <version>1.0-M1-SNAPSHOT</version> <scope>provided</scope> </dependency> --> | ||
| <dependency> | ||
| <groupId>boost.runtimes</groupId> | ||
| <artifactId>wlp</artifactId> |
There was a problem hiding this comment.
Should I change that to liberty rather than wlp? Also need to update the version.
| <dependency> | ||
| <groupId>net.wasdev.wlp.maven.plugins</groupId> | ||
| <artifactId>liberty-maven-plugin</artifactId> | ||
| <version>2.6.3</version> |
There was a problem hiding this comment.
Should update to new coordinates in openliberty.
| private String libertyServerPath; | ||
|
|
||
| private MavenProject project; | ||
| private ExecutionEnvironment env; |
There was a problem hiding this comment.
Use new coordinates below for LMP.
| public class WLPRuntime extends LibertyRuntime { | ||
|
|
||
| public WLPRuntime() { | ||
| super("com.ibm.websphere.appserver.runtime", "wlp-webProfile8", "19.0.0.7"); |
There was a problem hiding this comment.
Seeing the runtime and version hardcoded seems odd. Is this a default that can be overridden somewhere by the end user?
| compile "boost:boost-common:0.1.3-SNAPSHOT" | ||
| compile "boost.runtimes:liberty-common:0.1-SNAPSHOT" | ||
| compile "boost:boost-gradle-plugin:0.1.1-SNAPSHOT" | ||
| compile 'net.wasdev.wlp.gradle.plugins:liberty-gradle-plugin:2.6.6-SNAPSHOT' |
There was a problem hiding this comment.
I noticed we used 2.6.7-SNAPSHOT above.
| public void doPackage() throws BoostException { | ||
| public void doPackage(List<AbstractBoosterConfig> boosterConfigs, Object mavenProject, Object pluginTask) throws BoostException { | ||
| project = (MavenProject)mavenProject; | ||
| env = ((AbstractMojo)pluginTask).getExecutionEnvironment(); |
There was a problem hiding this comment.
I think all the casting suggests that we should have two distinct interfaces one from boost-maven and one from boost-gradle, and let the runtime impls decide if and how they want to factor the common pieces. The interface isn't doing a good job at showing what needs to be implemented.
| //String command = project.getProjectDir().toString() + "/gradlew"; | ||
| try { | ||
| ProcessBuilder pb = new ProcessBuilder("gradle", taskName, "-i", "-s"); | ||
| System.out.println("Executing task " + pb.command().get(1)); |
There was a problem hiding this comment.
Is this a pattern we've used anywhere before (kicking off another gradle invocation)? Or have seen anywhere? Just a bit hesitant to go too out on a limb.
3 participants
Added parameters to the runtime adapter functions.
Pulled out common logic for the Liberty runtimes into liberty-common.
Moved the booster tests for Liberty into liberty-common.
Added a WLP runtime adapter.
Added a Liberty runtime adapter for boost-gradle.
Pulled out Docker and Spring logic from boost-gradle.