Fix: remove signerMeta from the advanced permissions starter#86
Open
Fix: remove signerMeta from the advanced permissions starter#86
Conversation
…ermission handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Note
Low Risk
Low risk template fix that only changes how delegation parameters are read/validated; behavior should be unchanged aside from no longer failing on missing
signerMeta.Overview
Updates the advanced permissions starter’s
RedeemPermissionButtonto stop reading delegation data frompermission.signerMetaand instead usepermission.contextandpermission.delegationManagerdirectly.This removes the early error path for missing
signerMetaand keeps validation focused on the requiredcontext/delegationManagerfields before sending the delegated user operation.Written by Cursor Bugbot for commit 5be4caf. This will update automatically on new commits. Configure here.