update bdy imp3 by hand, remove j and update blocking loop#313
Open
MetBenjaminWent wants to merge 15 commits intoMetOffice:mainfrom
Open
update bdy imp3 by hand, remove j and update blocking loop#313MetBenjaminWent wants to merge 15 commits intoMetOffice:mainfrom
MetBenjaminWent wants to merge 15 commits intoMetOffice:mainfrom
Conversation
…pps into bdy_imp3-by-hand
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Remove the j loop which is adversely affecting performance in the boundary layer, and improve blocking loops.
Performance data can be found in the umbrella issue, #106 (TBD)
closes #314
Reviewer note, I'm yet to performance test this one, as fixes included in #231 are blocking this, as is the lack of max time in Vernier, which will need developing.
I'm going to finish all of the Wave 2 ones noted in #106 together and get updated performance data for each of these issues, and progress in the boundary layer.
Could the change-set be reviewed sans the performance data, just to keep this ticket moving, but hold the final approval until I've added this? Thanks
Sci/Tech Reviewer:
Code Reviewer: @mo-alistairp
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - bdy_imp3-by-hand/run15
Suite Information
Task Information
✅ succeeded tasks - 51
Test Suite Results - lfric_apps - bdy_imp3-by-hand/run16
Suite Information
Task Information
❌ failed tasks - 2
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review