Skip to content

Change fcm diff error message#207

Open
Pierre-siddall wants to merge 1 commit intoMetOffice:mainfrom
Pierre-siddall:fix-error-message
Open

Change fcm diff error message#207
Pierre-siddall wants to merge 1 commit intoMetOffice:mainfrom
Pierre-siddall:fix-error-message

Conversation

@Pierre-siddall
Copy link
Contributor

PR Summary

Sci/Tech Reviewer:
Code Reviewer: @t00sa

Fixes the misleading error message in umdp3 fixer which references fcm.

closes #189

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • This change has been tested appropriately (please describe)

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Security considerations have been addressed
  • Performance impact is acceptable

@Pierre-siddall Pierre-siddall requested a review from t00sa March 10, 2026 16:06
@Pierre-siddall Pierre-siddall self-assigned this Mar 10, 2026
@Pierre-siddall Pierre-siddall added the enhancement New feature or request label Mar 10, 2026
Copy link
Collaborator

@t00sa t00sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in line

shutil.rmtree(tmpdir)
raise ValueError(
"Ran fcm diff command and changes were made by "
"Ran git diff command and changes were made by "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost but not quite: if you look at the command above, it's running plain diff rather than git diff

Suggested change
"Ran git diff command and changes were made by "
"Ran diff command and changes were made by "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct error message in umdp3_fixer.py

2 participants