Fix bug in pathnames when using --fullcheck#201
Merged
james-bruten-mo merged 13 commits intoMetOffice:mainfrom Mar 9, 2026
Merged
Fix bug in pathnames when using --fullcheck#201james-bruten-mo merged 13 commits intoMetOffice:mainfrom
james-bruten-mo merged 13 commits intoMetOffice:mainfrom
Conversation
…es which git / VS Code are marking as in conflict. Annoyingly, this seems to have introduced a bug as well.
…esolving clashes. But looking at it, I really can't fathom out 'how'
…n't edited this file...
20 tasks
james-bruten-mo
approved these changes
Mar 9, 2026
Collaborator
james-bruten-mo
left a comment
There was a problem hiding this comment.
Looks good, cheers
r-sharp
added a commit
to r-sharp/SimSys_Scripts
that referenced
this pull request
Mar 9, 2026
* Yet another weird round of having to repeatedly accept the same changes which git / VS Code are marking as in conflict. Annoyingly, this seems to have introduced a bug as well. * Fixing issue with external runners not establishing properly. * Fixing an error that seems to have crept in during merging main and resolving clashes. But looking at it, I really can't fathom out 'how' * Where do these line length errors in the linter(s) come from - I haven't edited this file... * quick "improvement" to the error reporting in one of the tests * Why am I constantly having to re-impliment fixes/tidying I'm sure I've done before. * And now ruff_format wants to change them back again... * Fix issue with "TLD" being repeated for paths when using --fullcheck * Undoing auto formatting again as github CI doesn't agree with it (picard.gif)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: @james-bruten-mo
The TLD(Top Level Directory, as specified with the -p|--path argument) was being repeated when using --fullcheck option. Not sure how this crept in, but I discovered it when trying to work on some optimisations.
Whilst the propesed 'fix' might look a bit clunky (generating relative paths to the TLD in
get_files_to_checkonly to add the TLD once the list is returned). This is to accomodate planned changes to only add the TLD at the point the file is opened and always use just the relative path when reporting on the success/failure of a particular file.I'm fixing the bug here - no implementing the future change.
The list of commits below looks to include all the commints in Unifying the style checkers #196.
Only the commit 545580b relates to this bugfix...
Code Quality Checklist
Testing
On the command line, this change allows the script to run on a specified directory in both 'cms' and fullcheck modes.
It also passes all the pytest tests.
Security Considerations
AI Assistance and Attribution
AI only used for "line completion" where it matched what I was going to type.
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review