ENH: Improve Qt include path resolution macOS#271
ENH: Improve Qt include path resolution macOS#271hjmjohnson wants to merge 1 commit intoMeVisLab:masterfrom
Conversation
Add specific framework path handling Refactor include directory parsing to support multiple candidate paths for headers and introduce macOS-specific logic for resolving framework-relative header paths. Enhance generator flexibility and robustness for cross-platform usage. Push upstream fix via: danmar/simplecpp#448
| for (const QString &includeDir: getIncludeDirectories(commandLineIncludes)) | ||
| { | ||
| QFileInfo fi(QDir(includeDir), "qtcoreversion.h"); | ||
| std::list<std::string> candiate_paths; |
There was a problem hiding this comment.
typo: candidate_paths
| std::string get_apple_framework_relative_path(const std::string& header); | ||
|
|
There was a problem hiding this comment.
Does this have to be public, or could you just put it into an anonymous namespace in the implementation?
| } | ||
|
|
||
| #ifdef __APPLE__ | ||
| static std::string get_apple_framework_relative_path(const std::string& header) |
There was a problem hiding this comment.
Please try to use the same naming style (e.g. camel case) as the rest of the code.
|
I am working with the upstream simplecpp developers to finalize the changes. danmar/simplecpp#448 I'll make fixes there. It will probably be a few months before I get back to this. |
|
Ah, I had missed that this is from an upstream change. In this case it is of course preferrable to leave the code compatible, though it would be even better if you could change this upstream, thanks! |
|
@hjmjohnson This pull request can now be closed as it is superseded by the following pull request: 🙏 For the initial draft & investigative work, this was instrumental to understand the issues. |
|
Superseded by #302 |
3 participants
Add specific framework path handling
Refactor include directory parsing to support multiple candidate paths for headers and introduce macOS-specific logic for resolving framework-relative header paths. Enhance generator flexibility and robustness for cross-platform usage.
Push upstream fix via:
danmar/simplecpp#448