Export all symbols on Windows for the path string conversion functions#1
Open
straubar wants to merge 1 commit intoMarukyu:masterfrom
Open
Export all symbols on Windows for the path string conversion functions#1straubar wants to merge 1 commit intoMarukyu:masterfrom
straubar wants to merge 1 commit intoMarukyu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LuaVis uses the path string conversion functions defined in source/windows/FileNameConversions.cpp. These files are not marked for export and consequently are not added to the resulting DLL file on Windows.
I added to the CMake file the flag for exporting all symbols, thus making available these functions in the created library.