Reset auxiliary dataset picker actions#232
Merged
Conversation
Introduce helper lambdas to centralize dataset picker state updates: invalidateFilters() to invalidate dependent filters and resetAuxiliaryDatasets() to clear aux picker selections (setCurrentIndex(-1)). Connect the position picker signal to run the invalidation and connect position dataset change signals to reset auxiliary pickers so color/size/opacity selections are cleared when position datasets change. This removes duplicated calls and ensures auxiliary pickers don't hold stale selections.
ChangLi27
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way auxiliary dataset picker actions are managed in
DatasetsAction.cpp. Instead of invalidating filters and resetting indices directly in the constructor, the code now uses lambda functions and signal connections to ensure these actions are triggered automatically when relevant datasets change. This improves maintainability and ensures the UI remains consistent with the underlying data.Refactoring of dataset picker actions:
invalidateFilterslambda to centralize the logic for invalidating filters on auxiliary dataset picker actions, and connected it to the position dataset picker'sdatasetPickedsignal.resetAuxilliaryDatasetslambda to reset the selected indices of auxiliary dataset picker actions, and connected it to thechangedsignals of both the position and position source datasets.