replace template_spec test with config_variables test#4034
Open
khassel wants to merge 2 commits intoMagicMirrorOrg:developfrom
Open
replace template_spec test with config_variables test#4034khassel wants to merge 2 commits intoMagicMirrorOrg:developfrom
khassel wants to merge 2 commits intoMagicMirrorOrg:developfrom
Conversation
KristjanESPERANTO
requested changes
Feb 8, 2026
Collaborator
|
I'm not entirely sure, but I think the tests might not properly validate variable substitution? 🤔 The current tests check that
These tests would pass even if substitution was broken. A test for it("config.timeFormat should be 12 from MM_TIME_FORMAT variable", async () => {
expect(config.timeFormat).toBe(12); // default is 24
});This should better verify that substitution works. WDYT? |
Collaborator
|
By the way: I just wanted to say that I'm really excited that we can now hide the secrets from the front end 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After introducing new config loading this PR replaces the obsolete template test with a config test.