allow environment variables in cors urls#4033
Merged
KristjanESPERANTO merged 3 commits intoMagicMirrorOrg:developfrom Feb 8, 2026
Merged
allow environment variables in cors urls#4033KristjanESPERANTO merged 3 commits intoMagicMirrorOrg:developfrom
KristjanESPERANTO merged 3 commits intoMagicMirrorOrg:developfrom
Conversation
Collaborator
|
This looks great! Would it make sense to add a test for the new replaceSecretPlaceholder function? |
Collaborator
Author
done ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and centralize and optimize replace regex.
Another follow up to #4029
With this PR you can use secrets in urls in browser modules if you use the cors proxy.
I will provide a new section in the docs concerning secret handling before next release.