Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Add E2E integration tests
Description
LinkedToolsListeras the primary verification oracle, mirroring whatluca linkedreports to the user.desiredBinaryNameper tool (and bare URLs, no extension) ensure each tool produces a distinct symlink — avoiding the overwrite problem present in existing fixtures where all tools share the samebinaryPathbasename.Type of Change
How Has This Been Tested?
All 6 new E2E tests pass, and the full suite (160 tests) passes with no regressions.
Screenshots / Demo (if applicable)
Checklist
CI Considerations
Breaking Changes?
Additional Notes
New files:
Tests/Fixtures/Lucafiles/Lucafile_e2e_full.yml— 3 tools (MockToolA 1.0.0, MockToolB 2.0.0, MockToolC 3.0.0) each with a uniquedesiredBinaryNameTests/Fixtures/Lucafiles/Lucafile_e2e_subset.yml— MockToolB + MockToolC only, used to trigger orphan detection against MockToolATests/E2E/E2ETests.swift— 6 tests covering: uninstall leaves broken symlink, unlink preserves cache, unlink then reinstall restores link, subset spec orphans tool, unlink one leaves others intact, uninstall then reinstall re-downloads