Fix Codecov upload for fork pull requests#33
Merged
albertodebortoli merged 1 commit intomainfrom Mar 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
run-tests.ymlworkflow usedsecrets.CODECOV_TOKENdirectly in thepull_requestevent context. GitHub does not expose secrets to workflows triggered by PRs from forks, so the Codecov upload step was failing (and failing CI) for any fork-originated PR.upload-coverage.ymlworkflow triggered viaworkflow_run. The test jobs now save lcov reports as GitHub Actions artifacts (coverage-macos,coverage-linux). The new workflow downloads those artifacts and uploads them to Codecov after the test run completes — running in the base repository context where secrets are available.Type of Change
How Has This Been Tested?
Verified the workflow logic by inspection. The change can be validated end-to-end by opening a PR from a fork and confirming the
run-testsjobs pass and coverage is subsequently uploaded by theupload-coverageworkflow.Screenshots / Demo (if applicable)
N/A
Checklist
CI Considerations
CODECOV_TOKENsecret; no new secrets neededBreaking Changes?
Additional Notes
The
install curlstep in the Linux job has been removed as it was only needed for the Codecov upload, which now happens in the separate workflow.