Merged
Conversation
wojciech-graj
force-pushed
the
defmt
branch
3 times, most recently
from
12c05a3 to
cf66d10
Compare
Merged
Owner
|
does the LTO requirement affect downstream users of the crate? that would be rather troublesome if so. |
Contributor
Author
It would only affect them when enabling the defmt feature, which they'd only use for embedded targets for which all of these symbols would be defined. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of the formatting mirrors the
Debugimpls, since they are logically the same.LTO has to be enabled because the windows linker tries to resolve symbols before performing dead code elimination, and defmt requires additional crates to actually "work" in a binary.
The MSRV also has to be bumped to 1.60, because cargo checks the Cargo.toml files of all dependencies, even if they're optional and disabled, and the syntax was expanded with version 1.60. These new syntax features are used by proc-macro-error2, which is a dependency of defmt.