Skip to content

Refactor the search endpoint to allow for customisation.#9

Closed
alvinsw wants to merge 2 commits intomainfrom
customsearch
Closed

Refactor the search endpoint to allow for customisation.#9
alvinsw wants to merge 2 commits intomainfrom
customsearch

Conversation

@alvinsw
Copy link
Member

@alvinsw alvinsw commented Mar 9, 2026

Changes required to allow user to customise opensearch search query and result:
Extract the codes for building the opensearch search query into an extendable class.
Added queryBuilderClass and queryBuilderOptions to the main Options.

@alvinsw alvinsw requested a review from johnf March 9, 2026 04:45
@johnf
Copy link
Collaborator

johnf commented Mar 10, 2026

@alvinsw Can you remove dist please?

I'm not convinced we should commit it (although I'm open to discussing it).
Even if we agree, it should be in a separate PR.

Can you expand more on the use case for it?

@alvinsw
Copy link
Member Author

alvinsw commented Mar 12, 2026

The dist folder is required when we want to add dependency directly from the github repo eg "arocapi": "Language-Research-Technology/arocapi#customsearch". It's in this PR just because other people can test the ldacapi version that uses this branch without having to clone arocapi and do manual npm link.

@johnf
Copy link
Collaborator

johnf commented Mar 12, 2026

@alvinsw It makes it very difficult to review with all the dist stuff sitting in there, and I want to make sure we don't accidentally merge it.

Can you please remove from this PR and perhaps create another branch for your use case that includes the dist others can use?
To be honest, it's not super difficult to npm link, which is what I'd typically do if I had this issue.

@alvinsw alvinsw closed this Mar 13, 2026
@alvinsw alvinsw deleted the customsearch branch March 13, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants