-
Notifications
You must be signed in to change notification settings - Fork 9
Add sample finder test for multi choice field #2903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DariaBod
wants to merge
7
commits into
develop
Choose a base branch
from
fb_multiChoiceSampleFinder
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+86
−2
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
814a354
add sample finder test for multi choice field
DariaBod c3aef8d
Merge branch 'develop' into fb_multiChoiceSampleFinder
DariaBod 56a9493
Merge branch 'develop' into fb_multiChoiceSampleFinder
DariaBod 2085209
fix part of comments
DariaBod 8d01d6d
Merge branch 'develop' into fb_multiChoiceSampleFinder
DariaBod 510a266
add values with tricky characters
DariaBod 5c20403
fix filtering issue
DariaBod File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| package org.labkey.test.util.data; | ||
|
|
||
| import org.labkey.remoteapi.query.Filter; | ||
|
|
||
| import java.util.Comparator; | ||
| import java.util.LinkedHashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| import static org.labkey.test.util.samplemanagement.SMTestUtils.COL_SAMPLE_ID_NAME; | ||
| import static org.labkey.test.util.samplemanagement.SMTestUtils.COL_SAMPLE_NAME_NAME; | ||
|
|
||
| public class TestArrayDataUtils | ||
| { | ||
|
|
||
| public static<T> Map<String, T> getMapWithIdAndMultiChoiceField(List<Map<String, T>> data) | ||
| { | ||
| return data.stream() | ||
| .collect(Collectors.toMap( | ||
| row -> String.valueOf(row.get(COL_SAMPLE_NAME_NAME)!=null?row.get(COL_SAMPLE_NAME_NAME):row.get(COL_SAMPLE_ID_NAME)), | ||
| row -> {String complexKey = row.keySet().stream() | ||
| .filter(k -> k.contains("Multi Choice")) | ||
| .findFirst() | ||
| .orElse(""); | ||
| return row.get(complexKey);} | ||
| )); | ||
| } | ||
|
|
||
| /** | ||
| * Filtering Map according to filter and then sorting values in alphabetical order. | ||
| * | ||
| * @return filtered Map | ||
| */ | ||
| public static <T> Map<String, String> filterMap(Map<String, T> map, List<String> searchValues, Filter.Operator filterType) | ||
| { | ||
| Comparator<String> comparator = Comparator.comparing((String s) -> s.toLowerCase()).thenComparing(s -> s); | ||
| return map.entrySet().stream() | ||
| .filter(entry -> entry.getValue() instanceof List) | ||
| .map(entry -> Map.entry(entry.getKey(), (List<String>) entry.getValue())) | ||
| .filter(entry -> isMatch(entry.getValue(), searchValues, filterType)) | ||
| .collect(Collectors.toMap( | ||
| Map.Entry::getKey, | ||
| e -> e.getValue().stream() | ||
| .sorted(comparator) | ||
| .collect(Collectors.joining(", ")), | ||
| (e1, e2) -> e1, | ||
| LinkedHashMap::new | ||
| )); | ||
| } | ||
|
|
||
| private static boolean isMatch(List<String> actualValues, List<String> searchValues, Filter.Operator type) | ||
| { | ||
| return switch (type) | ||
| { | ||
| case ARRAY_CONTAINS_ALL -> actualValues.containsAll(searchValues); | ||
| case ARRAY_CONTAINS_ANY -> searchValues.stream().anyMatch(actualValues::contains); | ||
| case ARRAY_CONTAINS_EXACT -> actualValues.size() == searchValues.size() && actualValues.containsAll(searchValues); | ||
| case ARRAY_CONTAINS_NONE -> searchValues.stream().noneMatch(actualValues::contains); | ||
| case ARRAY_CONTAINS_NOT_EXACT -> !(actualValues.size() == searchValues.size() && actualValues.containsAll(searchValues)); | ||
| case ARRAY_ISEMPTY -> actualValues.isEmpty(); | ||
| case ARRAY_ISNOTEMPTY -> !actualValues.isEmpty(); | ||
| default -> true; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this default to |
||
| }; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider moving
TestDataUtils.parseMultiValueTextandResponsiveGrid.ARRAY_OPERATORSinto this class.